Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Issue 92074: Fix version.bat to use the 'default' svn in the PATH and not a precooked one ... (Closed)

Created:
11 years, 8 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Nicolas Sylvain
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix version.bat to use the 'default' svn in the PATH and not a precooked one in chromium sources. BUG=10872 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14312

Patch Set 1 #

Patch Set 2 : Made it work without svn being installed #

Patch Set 3 : Verified both with and without; fixed all the bugs accordingly, %VarsBat% needs to be always called #

Patch Set 4 : Made it slightly more consistent, fixed some comments, VS now picks up the warning #

Patch Set 5 : Made it error when building an official build (to trap regressions) #

Patch Set 6 : better handling #

Patch Set 7 : copyright #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -6 lines) Patch
M chrome/tools/build/win/version.bat View 1 2 3 4 5 6 2 chunks +30 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
M-A Ruel
11 years, 8 months ago (2009-04-23 13:44:24 UTC) #1
M-A Ruel
11 years, 8 months ago (2009-04-23 13:56:28 UTC) #2
Nicolas Sylvain
11 years, 8 months ago (2009-04-23 15:16:32 UTC) #3
lgtm with set LASTCHANGE=0 >> %VarsBat%

Powered by Google App Engine
This is Rietveld 408576698