Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart

Issue 920703002: cps2js: Clean up some obsolete TODOs. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart
diff --git a/pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart b/pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart
index 038ecf16120824c81aacf5644c2f79038439cf0b..4312130deaa2b4bbc058c94fd8199a04fd8c6eff 100644
--- a/pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart
+++ b/pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart
@@ -330,7 +330,7 @@ class Not extends Expression {
accept1(ExpressionVisitor1 visitor, arg) => visitor.visitNot(this, arg);
}
-class FunctionExpression extends Expression {
+class FunctionExpression extends Expression implements DartSpecificNode {
final FunctionDefinition definition;
FunctionExpression(this.definition) {
@@ -348,7 +348,7 @@ class FunctionExpression extends Expression {
/// being recursive or having a return type.
/// The [variable] must not occur as the left-hand side of an [Assign] or
/// any other [FunctionDeclaration].
-class FunctionDeclaration extends Statement {
+class FunctionDeclaration extends Statement implements DartSpecificNode {
Variable variable;
final FunctionDefinition definition;
Statement next;
@@ -612,7 +612,7 @@ class FunctionDefinition extends Node implements ExecutableDefinition {
applyPass(Pass pass) => pass.rewriteFunctionDefinition(this);
}
-abstract class Initializer implements Expression {}
+abstract class Initializer implements Expression, DartSpecificNode {}
class FieldInitializer extends Initializer {
final FieldElement element;
@@ -657,6 +657,8 @@ class ConstructorDefinition extends FunctionDefinition {
abstract class JsSpecificNode implements Node {}
+abstract class DartSpecificNode implements Node {}
+
class CreateBox extends Expression implements JsSpecificNode {
accept(ExpressionVisitor visitor) => visitor.visitCreateBox(this);
accept1(ExpressionVisitor1 visitor, arg) => visitor.visitCreateBox(this, arg);

Powered by Google App Engine
This is Rietveld 408576698