Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: components/password_manager/core/browser/password_form_manager.h

Issue 920683002: [Password Generation] Add negative votes for crowdsourcing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Test fixes Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager.h
diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h
index ddd113a2f272d53c8b674247fa9b35c8cb85baaa..9256b35331ccafc6218a82243cb4bae4db296db3 100644
--- a/components/password_manager/core/browser/password_form_manager.h
+++ b/components/password_manager/core/browser/password_form_manager.h
@@ -251,8 +251,10 @@ class PasswordFormManager : public PasswordStoreConsumer {
// Check to see if |pending| corresponds to an account creation form. If we
// think that it does, we label it as such and upload this state to the
// Autofill server, so that we will trigger password generation in the future.
- void CheckForAccountCreationForm(const autofill::PasswordForm& pending,
- const autofill::PasswordForm& observed);
+ // This function will update generation_upload_status of |pending| if an
+ // upload is performed.
+ void CheckForAccountCreationForm(const autofill::PasswordForm& observed,
+ autofill::PasswordForm* pending);
// Update all login matches to reflect new preferred state - preferred flag
// will be reset on all matched logins that different than the current
@@ -277,10 +279,10 @@ class PasswordFormManager : public PasswordStoreConsumer {
// duplicates.
void SanitizePossibleUsernames(autofill::PasswordForm* form);
- // Helper function to delegate uploading to the AutofillManager.
- virtual void UploadPasswordForm(
- const autofill::FormData& form_data,
- const autofill::ServerFieldType& password_type);
+ // Helper function to delegate uploading to the AutofillManager. Returns true
+ // on success.
+ bool UploadPasswordForm(const autofill::FormData& form_data,
+ const autofill::ServerFieldType& password_type);
// Set of PasswordForms from the DB that best match the form
// being managed by this. Use a map instead of vector, because we most

Powered by Google App Engine
This is Rietveld 408576698