Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: components/autofill/core/common/password_form.h

Issue 920683002: [Password Generation] Add negative votes for crowdsourcing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Test fixes Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/autofill/core/browser/field_types.h ('k') | components/autofill/core/common/password_form.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/common/password_form.h
diff --git a/components/autofill/core/common/password_form.h b/components/autofill/core/common/password_form.h
index 927befc0b623096b80b6515a960ef9b11ae84de0..783eda54786c8e433d20807d7799e65c5523b62b 100644
--- a/components/autofill/core/common/password_form.h
+++ b/components/autofill/core/common/password_form.h
@@ -38,6 +38,16 @@ namespace autofill {
// entry to the database and how they can affect the matching process.
struct PasswordForm {
+ // Enum to keep track of what information has been sent to the server about
+ // this form regarding password generation.
+ enum GenerationUploadStatus {
+ NO_SIGNAL_SENT,
+ POSITIVE_SIGNAL_SENT,
+ NEGATIVE_SIGNAL_SENT,
+ // Reserve a few values for future use.
+ UNKNOWN_STATUS = 10
+ };
+
// Enum to differentiate between HTML form based authentication, and dialogs
// using basic or digest schemes. Default is SCHEME_HTML. Only PasswordForms
// of the same Scheme will be matched/autofilled against each other.
@@ -207,6 +217,9 @@ struct PasswordForm {
// When parsing an HTML form, this is normally set.
FormData form_data;
+ // What information has been sent to the Autofill server about this form.
+ GenerationUploadStatus generation_upload_status;
+
// These following fields are set by a website using the Credential Manager
// API. They will be empty and remain unused for sites which do not use that
// API.
« no previous file with comments | « components/autofill/core/browser/field_types.h ('k') | components/autofill/core/common/password_form.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698