chrome/browser/password_manager/native_backend_libsecret.cc - Issue 920683002: [Password Generation] Add negative votes for crowdsourcing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/native_backend_libsecret.cc

Issue 920683002: [Password Generation] Add negative votes for crowdsourcing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Test fixes Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc ('k') | chrome/browser/password_manager/native_backend_libsecret_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/native_backend_libsecret.cc

diff --git a/chrome/browser/password_manager/native_backend_libsecret.cc b/chrome/browser/password_manager/native_backend_libsecret.cc

index d23ac4512d3f69b61d61869b237cd5619c4c8da2..43673a3532b6f968a288df3228d4b56ad4fbd435 100644

--- a/chrome/browser/password_manager/native_backend_libsecret.cc

+++ b/chrome/browser/password_manager/native_backend_libsecret.cc

@@ -120,6 +120,7 @@ const SecretSchema kLibsecretSchema = {

{"avatar_url", SECRET_SCHEMA_ATTRIBUTE_STRING},

{"federation_url", SECRET_SCHEMA_ATTRIBUTE_STRING},

{"skip_zero_click", SECRET_SCHEMA_ATTRIBUTE_INTEGER},

+ {"generation_upload_status", SECRET_SCHEMA_ATTRIBUTE_INTEGER},

// This field is always "chrome-profile_id" so that we can search for it.

{"application", SECRET_SCHEMA_ATTRIBUTE_STRING},

{nullptr, SECRET_SCHEMA_ATTRIBUTE_STRING}}};

@@ -190,6 +191,9 @@ scoped_ptr<PasswordForm> FormOutOfAttributes(GHashTable* attrs) {

form->avatar_url = GURL(GetStringFromAttributes(attrs, "avatar_url"));

form->federation_url = GURL(GetStringFromAttributes(attrs, "federation_url"));

form->skip_zero_click = GetUintFromAttributes(attrs, "skip_zero_click");

+ form->generation_upload_status =

+ static_cast<PasswordForm::GenerationUploadStatus>(

+ GetUintFromAttributes(attrs, "generation_upload_status"));

return form.Pass();

}

@@ -439,6 +443,7 @@ bool NativeBackendLibsecret::RawAddLogin(const PasswordForm& form) {

"avatar_url", form.avatar_url.spec().c_str(),

"federation_url", form.federation_url.spec().c_str(),

"skip_zero_click", form.skip_zero_click,

+ "generation_upload_status", form.generation_upload_status,

"application", app_string_.c_str(), nullptr);

if (error) {