Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7544)

Unified Diff: chrome/browser/password_manager/native_backend_gnome_x.cc

Issue 920683002: [Password Generation] Add negative votes for crowdsourcing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Test fixes Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/password_manager/native_backend_gnome_x_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/native_backend_gnome_x.cc
diff --git a/chrome/browser/password_manager/native_backend_gnome_x.cc b/chrome/browser/password_manager/native_backend_gnome_x.cc
index bf98cd1e78130f2d7276b18f1b5fffecacf0eafd..7dc37db4490002b8c4a1a018d556140b83ea5e29 100644
--- a/chrome/browser/password_manager/native_backend_gnome_x.cc
+++ b/chrome/browser/password_manager/native_backend_gnome_x.cc
@@ -155,6 +155,9 @@ scoped_ptr<PasswordForm> FormFromAttributes(GnomeKeyringAttributeList* attrs) {
form->avatar_url = GURL(string_attr_map["avatar_url"]);
form->federation_url = GURL(string_attr_map["federation_url"]);
form->skip_zero_click = uint_attr_map["skip_zero_click"];
+ form->generation_upload_status =
+ static_cast<PasswordForm::GenerationUploadStatus>(
+ uint_attr_map["generation_upload_status"]);
return form.Pass();
}
@@ -243,6 +246,7 @@ const GnomeKeyringPasswordSchema kGnomeSchema = {
{ "avatar_url", GNOME_KEYRING_ATTRIBUTE_TYPE_STRING },
{ "federation_url", GNOME_KEYRING_ATTRIBUTE_TYPE_STRING },
{ "skip_zero_click", GNOME_KEYRING_ATTRIBUTE_TYPE_UINT32 },
+ { "generation_upload_status", GNOME_KEYRING_ATTRIBUTE_TYPE_UINT32 },
// This field is always "chrome" so that we can search for it.
{ "application", GNOME_KEYRING_ATTRIBUTE_TYPE_STRING },
{ NULL }
@@ -362,6 +366,7 @@ void GKRMethod::AddLogin(const PasswordForm& form, const char* app_string) {
"avatar_url", form.avatar_url.spec().c_str(),
"federation_url", form.federation_url.spec().c_str(),
"skip_zero_click", form.skip_zero_click,
+ "generation_upload_status", form.generation_upload_status,
"application", app_string,
NULL);
}
« no previous file with comments | « no previous file | chrome/browser/password_manager/native_backend_gnome_x_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698