Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 920653002: Use StringKeyframes to make CSS Animations responsive to style changes. (Closed)

Created:
5 years, 10 months ago by shend
Modified:
5 years, 9 months ago
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@string-keyframes
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use StringKeyframes to make CSS Animations responsive to style changes. When a animated property is absent in the 0% or 100% keyframe, a neutral keyframe is created which takes the value of the computed style. When the computed style changes, the spec requires that the neutral keyframe is updated accordingly to match the new style. This patch switches from AnimatableValueKeyframe over to StringKeyframe in CSS animations. The only place that still uses AnimatableValueKeyframe is transitions. This patch also introduces behaviour changes for interpolating SVG stroke-width, opacity and shape-image-transform. The new behaviours of these interpolations in CSS animations match that of web animations. When there is a non-animation style change, neutral keyframes are updated. Firefox handles this correctly, but IE11 doesn't. BUG=361948

Patch Set 1 #

Patch Set 2 : Rebase + add test #

Patch Set 3 : Update layout tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -24 lines) Patch
M LayoutTests/animations/interpolation/opacity-interpolation-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/animations/interpolation/shape-image-threshold-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/animations/interpolation/svg-stroke-width-interpolation-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
A LayoutTests/animations/responsive-neutral-keyframes.html View 1 1 chunk +101 lines, -0 lines 0 comments Download
A ManualTests/animation/compositor-neutral-keyframes.html View 1 chunk +52 lines, -0 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 9 chunks +37 lines, -19 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
shend
5 years, 10 months ago (2015-02-13 04:01:17 UTC) #2
This is the patch that actually switches CSS animations to use responsive
behaviour.

Powered by Google App Engine
This is Rietveld 408576698