Move SkOSFile::Iter impls into ports.

Move SkOSFile::Iter impls into ports.

This was one large ifdef in SkOSFile.cpp in utils.
This moves the code to existing ports files.

Committed: https://skia.googlesource.com/skia/+/e998b7ff3a398eaa2f359d4af1a1898ea2824938

[bungeman-skia, 2015-02-11 22:41:26]

bungeman@google.com changed reviewers:
+ reed@google.com

[bungeman-skia, 2015-02-11 22:41:27]

I took a look at this again due to the confusion over using readdir or
readdir_r. At the time I though we'd want to move to readdir_r, so I started by
pulling the SkOSFile::Iter implementations into their platform specific files. I
don't believe the follow-up is needed anymore, but since I'd already done this,
it seems like a good clean up.

This has several benefits:
Remove the ifdefs.
Move code into (already existing) platform specific implementation files.
Starts clean up of this code into ports. (Include in include/core, but impl in
ports and utils.)

Follow ups:
Move header to ports.
Move the last bits of code left in utils impl somewhere else (possibly into own
impl file).

[bungeman-skia, 2015-02-11 22:41:31]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2015-02-11 22:42:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/920593002/20001

[commit-bot: I haz the power, 2015-02-11 22:42:07]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-02-12 04:42 UTC

[commit-bot: I haz the power, 2015-02-11 22:42:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-11 22:42:10]

Presubmit check for 920593002-20001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of:
('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org',
'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com')

Was the presubmit check useful? If not, run "git cl presubmit -v"
to figure out which PRESUBMIT.py was run, then run git blame
on the file to figure out who to ask for help.

[bungeman-skia, 2015-02-11 22:43:32]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2015-02-11 22:44:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/920593002/20001

[commit-bot: I haz the power, 2015-02-11 22:49:37]

This issue passed the CQ. To commit it, remove "COMMIT=false" from
the description and try again.

[reed1, 2015-02-12 14:28:25]

lgtm

https://codereview.chromium.org/920593002/diff/20001/include/core/SkOSFile.h
File include/core/SkOSFile.h (right):

https://codereview.chromium.org/920593002/diff/20001/include/core/SkOSFile.h#...
include/core/SkOSFile.h:106: static const size_t StorageSize = 40;
nit: convention would be kStorageSize

[bungeman-skia, 2015-02-12 15:10:40]

New patchsets have been uploaded after l-g-t-m from reed@google.com

[bungeman-skia, 2015-02-12 15:11:38]

https://codereview.chromium.org/920593002/diff/20001/include/core/SkOSFile.h
File include/core/SkOSFile.h (right):

https://codereview.chromium.org/920593002/diff/20001/include/core/SkOSFile.h#...
include/core/SkOSFile.h:106: static const size_t StorageSize = 40;
On 2015/02/12 14:28:25, reed1 wrote:
> nit: convention would be kStorageSize

Done.

[bungeman-skia, 2015-02-12 15:11:58]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2015-02-12 15:12:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/920593002/40001

[commit-bot: I haz the power, 2015-02-12 15:18:30]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/e998b7ff3a398eaa2f359d4af1a1898ea2824938