Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 920573004: [turbofan] Fix control reducer for dead loops. (Closed)

Created:
5 years, 10 months ago by titzer
Modified:
5 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix control reducer for dead loops. Note OSR special case. Also improved robustness of OSR tests. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/00d70d63e6975b0663c50c7c619111152ea1cb1c Cr-Commit-Position: refs/heads/master@{#26686}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -36 lines) Patch
M src/compiler/control-reducer.h View 1 chunk +4 lines, -3 lines 0 comments Download
M src/compiler/control-reducer.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M src/compiler/osr.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-control-reducer.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-osr.cc View 10 chunks +25 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
titzer
5 years, 10 months ago (2015-02-17 10:59:06 UTC) #1
Michael Starzinger
LGTM.
5 years, 10 months ago (2015-02-17 11:27:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/920573004/1
5 years, 10 months ago (2015-02-17 11:32:48 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 11:52:38 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 11:53:00 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/00d70d63e6975b0663c50c7c619111152ea1cb1c
Cr-Commit-Position: refs/heads/master@{#26686}

Powered by Google App Engine
This is Rietveld 408576698