Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 920543005: X87: new classes: no longer experimental. (Closed)

Created:
5 years, 10 months ago by chunyang.dai
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: new classes: no longer experimental. port 2707d4c9f4b6e6e600e708b3b08b09d27d594ce7 (r26628). original commit message: This CL fixes tests that no longer valid and also fixes two issues: 1. 'super()' in non derived constructors. 2. Failure to step into derived constructors. BUG= Committed: https://crrev.com/a34ed97234883129d1bc8d32ecdd7b0fb7e5a2b7 Cr-Commit-Position: refs/heads/master@{#26647}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M src/x87/builtins-x87.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 10 months ago (2015-02-13 02:22:28 UTC) #2
Dmitry Lomov (no reviews)
lgtm
5 years, 10 months ago (2015-02-13 16:27:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/920543005/1
5 years, 10 months ago (2015-02-15 01:17:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-15 01:50:48 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-15 01:51:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a34ed97234883129d1bc8d32ecdd7b0fb7e5a2b7
Cr-Commit-Position: refs/heads/master@{#26647}

Powered by Google App Engine
This is Rietveld 408576698