Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 920543004: MIPS: new classes: implement correct check for uninitialized this in 'super()' (Closed)

Created:
5 years, 10 months ago by akos.palfi.imgtec
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: new classes: implement correct check for uninitialized this in 'super()' Port fdcf3e59ba4af1aa3c5b31a18e615169c97958ab BUG= R=paul.lind@imgtec.com Committed: https://chromium.googlesource.com/v8/v8/+/58d8e169f104021d2a62702b2c6e457ccd785833

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -24 lines) Patch
M src/mips/full-codegen-mips.cc View 2 chunks +11 lines, -12 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 2 chunks +11 lines, -12 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
akos.palfi.imgtec
PTAL.
5 years, 10 months ago (2015-02-12 22:05:45 UTC) #2
paul.l...
lgtm
5 years, 10 months ago (2015-02-12 23:09:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/920543004/1
5 years, 10 months ago (2015-02-12 23:24:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/2878)
5 years, 10 months ago (2015-02-12 23:26:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/920543004/1
5 years, 10 months ago (2015-02-13 00:03:44 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/2968)
5 years, 10 months ago (2015-02-13 00:11:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/920543004/1
5 years, 10 months ago (2015-02-13 00:46:24 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/2970)
5 years, 10 months ago (2015-02-13 00:51:38 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/58d8e169f104021d2a62702b2c6e457ccd785833 Cr-Commit-Position: refs/heads/master@{#26634}
5 years, 10 months ago (2015-02-13 01:22:53 UTC) #16
akos.palfi.imgtec
5 years, 10 months ago (2015-02-13 01:23:14 UTC) #17
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
58d8e169f104021d2a62702b2c6e457ccd785833 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698