Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: tools/telemetry/telemetry/value/trace_unittest.py

Issue 920523002: [Telemetry] Reduce memory usage in presence of TraceValues (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Ned's comments and fix bad logic Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/value/trace_unittest.py
diff --git a/tools/telemetry/telemetry/value/trace_unittest.py b/tools/telemetry/telemetry/value/trace_unittest.py
index a197a9ca8288cac2ca2a0e3dcb5d7a37fd4e3ebe..8f03b8aa30059ff8edc24da2424204468071b2e6 100644
--- a/tools/telemetry/telemetry/value/trace_unittest.py
+++ b/tools/telemetry/telemetry/value/trace_unittest.py
@@ -106,23 +106,14 @@ class NoLeakedTempfilesTests(TestBase):
self.actual_tempdir = trace.tempfile.tempdir
trace.tempfile.tempdir = self.temp_test_dir
- def testNoLeakedTempFileWhenTraceSerialize(self):
- tempdir = tempfile.mkdtemp()
- v = trace.TraceValue(None, trace_data.TraceData({'test': 1}))
- fh = v.Serialize(tempdir)
- try:
- shutil.rmtree(fh.GetAbsPath(), ignore_errors=True)
- self.assertTrue(tempdir)
- finally:
- shutil.rmtree(tempdir)
- self.assertTrue(_IsEmptyDir(self.temp_test_dir))
+ def testNoLeakedTempFileOnImplicitCleanUp(self):
+ with trace.TraceValue(None, trace_data.TraceData({'test': 1})):
+ pass
+ self.assertTrue(_IsEmptyDir(self.temp_test_dir))
def testNoLeakedTempFileWhenUploadingTrace(self):
v = trace.TraceValue(None, trace_data.TraceData({'test': 1}))
- trace.cloud_storage.SetCalculatedHashesForTesting(
- TestDefaultDict(123))
- bucket = trace.cloud_storage.PUBLIC_BUCKET
- v.UploadToCloud(bucket)
+ v.CleanUp()
self.assertTrue(_IsEmptyDir(self.temp_test_dir))
def tearDown(self):

Powered by Google App Engine
This is Rietveld 408576698