Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: src/effects/SkColorFilterImageFilter.cpp

Issue 920513003: Make filters use SkImage instead of SkBitmap Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/effects/SkColorFilterImageFilter.cpp
diff --git a/src/effects/SkColorFilterImageFilter.cpp b/src/effects/SkColorFilterImageFilter.cpp
index 0a4a693ab0ce71e0272bbf251e548a734b1c774f..41b8c88db376f96dc5d495fe368d9dc6ff4c8b63 100755
--- a/src/effects/SkColorFilterImageFilter.cpp
+++ b/src/effects/SkColorFilterImageFilter.cpp
@@ -9,7 +9,7 @@
#include "SkBitmap.h"
#include "SkCanvas.h"
#include "SkColorMatrixFilter.h"
-#include "SkDevice.h"
+#include "SkSurface.h"
#include "SkColorFilter.h"
#include "SkReadBuffer.h"
#include "SkTableColorFilter.h"
@@ -133,33 +133,38 @@ SkColorFilterImageFilter::~SkColorFilterImageFilter() {
fColorFilter->unref();
}
-bool SkColorFilterImageFilter::onFilterImage(Proxy* proxy, const SkBitmap& source,
+bool SkColorFilterImageFilter::onFilterImage(Proxy* proxy, SkImage& source,
const Context& ctx,
- SkBitmap* result,
+ SkAutoTUnref<SkImage>& result,
SkIPoint* offset) const {
- SkBitmap src = source;
+ SkAutoTUnref<SkImage> src(SkRef(&source));
SkIPoint srcOffset = SkIPoint::Make(0, 0);
- if (getInput(0) && !getInput(0)->filterImage(proxy, source, ctx, &src, &srcOffset)) {
+ if (getInput(0) && !getInput(0)->filterImage(proxy, source, ctx, src, &srcOffset)) {
return false;
}
SkIRect bounds;
- if (!this->applyCropRect(ctx, src, srcOffset, &bounds)) {
+ if (!this->applyCropRect(ctx, *src, srcOffset, &bounds)) {
return false;
}
- SkAutoTUnref<SkBaseDevice> device(proxy->createDevice(bounds.width(), bounds.height()));
- if (NULL == device.get()) {
+ SkAutoTUnref<SkSurface> surface(proxy->createSurface(bounds.width(), bounds.height()));
+ if (NULL == surface) {
return false;
}
- SkCanvas canvas(device.get());
+ SkCanvas* canvas = surface->getCanvas();
SkPaint paint;
paint.setXfermodeMode(SkXfermode::kSrc_Mode);
paint.setColorFilter(fColorFilter);
- canvas.drawSprite(src, srcOffset.fX - bounds.fLeft, srcOffset.fY - bounds.fTop, &paint);
+ canvas->drawImage(src, srcOffset.fX - bounds.fLeft, srcOffset.fY - bounds.fTop, &paint);
+
+ SkImage* image = surface->newImageSnapshot(SkSurface::kYes_Budgeted);
+ if (NULL == image) {
+ return false;
+ }
+ result.reset(image);
- *result = device.get()->accessBitmap(false);
offset->fX = bounds.fLeft;
offset->fY = bounds.fTop;
return true;

Powered by Google App Engine
This is Rietveld 408576698