Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(309)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Issue
92051
: Merge: chromium side [42671:42725]... (Closed)
Created:
11 years, 8 months ago by
levin
Modified:
9 years, 7 months ago
Reviewers:
Dmitry Titov
CC:
chromium-reviews_googlegroups.com
Base URL:
svn://chrome-svn/chrome/trunk/src/
Visibility:
Public.
Description
Merge: chromium side [42671:42725] Rebaselines:
http://trac.webkit.org/changeset/42722
resulted in LayoutTests/editing/inserting/insert-3907422-fix.html LayoutTests/editing/pasteboard/paste-text-015.html LayoutTests/editing/style/font-family-with-space.html
http://trac.webkit.org/changeset/42723
resulted in LayoutTests/editing/selection/select-all-iframe.html LayoutTests/svg/custom/pointer-events-path.svg
http://trac.webkit.org/changeset/42716
resulted in LayoutTests/fast/dom/HTMLSelectElement/named-options.html
http://trac.webkit.org/changeset/42725
Broke the close event behavior and resulted in disabling these ui tests: * BrowserCloseBeforeUnloadOK and * BrowserCloseBeforeUnloadCancel Committed:
http://src.chromium.org/viewvc/chrome?view=rev&revision=14291
Patch Set 1
#
Patch Set 2 : ''
#
Patch Set 3 : ''
#
Created:
11 years, 8 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+110 lines, -84 lines
)
Patch
M
DEPS
View
1 chunk
+1 line, -1 line
0 comments
Download
M
WEBKIT_MERGE_REVISION
View
1 chunk
+1 line, -1 line
0 comments
Download
M
chrome/browser/unload_uitest.cc
View
2 chunks
+2 lines, -2 lines
0 comments
Download
M
webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/inserting/insert-3907422-fix-expected.txt
View
2 chunks
+28 lines, -28 lines
0 comments
Download
M
webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/pasteboard/paste-text-015-expected.checksum
View
1 chunk
+1 line, -1 line
0 comments
Download
M
webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/pasteboard/paste-text-015-expected.png
View
Binary file
0 comments
Download
M
webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/pasteboard/paste-text-015-expected.txt
View
2 chunks
+23 lines, -35 lines
0 comments
Download
M
webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/selection/select-all-iframe-expected.txt
View
1 chunk
+2 lines, -2 lines
0 comments
Download
M
webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/style/font-family-with-space-expected.txt
View
1 chunk
+5 lines, -5 lines
0 comments
Download
A
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/cell-coalescing-expected.checksum
View
1 chunk
+1 line, -0 lines
0 comments
Download
A
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/cell-coalescing-expected.png
View
Binary file
0 comments
Download
A
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/cell-coalescing-expected.txt
View
1 chunk
+15 lines, -0 lines
0 comments
Download
M
webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/custom/pointer-events-path-expected.txt
View
1 chunk
+0 lines, -1 line
0 comments
Download
M
webkit/glue/webframe_impl.cc
View
1 chunk
+1 line, -1 line
0 comments
Download
M
webkit/port/bindings/v8/v8_custom.cpp
View
5 chunks
+6 lines, -6 lines
0 comments
Download
M
webkit/tools/layout_tests/test_expectations.txt
View
1
1 chunk
+24 lines, -1 line
0 comments
Download
Messages
Total messages: 2 (0 generated)
Expand Messages
|
Collapse Messages
levin
11 years, 8 months ago (2009-04-22 23:52:06 UTC)
#1
Dmitry Titov
LGTM, need to make sure the new images are right, as per offline chat.
11 years, 8 months ago (2009-04-23 00:23:20 UTC)
#2
LGTM, need to make sure the new images are right, as per offline chat.
Expand Messages
|
Collapse Messages
Issue 92051: Merge: chromium side [42671:42725]... (Closed)
Created 11 years, 8 months ago by levin
Modified 9 years, 7 months ago
Reviewers: Dmitry Titov
Base URL: svn://chrome-svn/chrome/trunk/src/
Comments: 0
This is Rietveld
408576698
Chromium Code Reviews
Issue
92051:
Merge: chromium side [42671:42725]... (Closed)
