Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 920503002: X87: Assembler support for internal references. (Closed)

Created:
5 years, 10 months ago by chunyang.dai
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Assembler support for internal references. port 5c119485b485a5c71155501613ae3c12be2863a8 (r26478). original commit message: Assembler support for internal references. BUG= Committed: https://crrev.com/a10ed727bcb610dab80950cc12dc5867c329d8c6 Cr-Commit-Position: refs/heads/master@{#26648}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -17 lines) Patch
M src/x87/assembler-x87.h View 1 7 chunks +17 lines, -5 lines 0 comments Download
M src/x87/assembler-x87.cc View 1 5 chunks +37 lines, -11 lines 0 comments Download
M src/x87/disasm-x87.cc View 2 chunks +3 lines, -1 line 0 comments Download
M test/cctest/test-assembler-x87.cc View 1 chunk +94 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
chunyang.dai
WL. PTAL. thanks
5 years, 10 months ago (2015-02-11 14:46:29 UTC) #2
chunyang.dai
hello. Benedikt. PTAL because one test case is ported. thanks
5 years, 10 months ago (2015-02-11 14:50:15 UTC) #4
Weiliang
lgtm
5 years, 10 months ago (2015-02-11 15:06:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/920503002/1
5 years, 10 months ago (2015-02-11 15:07:14 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/513)
5 years, 10 months ago (2015-02-11 15:11:29 UTC) #9
Benedikt Meurer
lgtm
5 years, 10 months ago (2015-02-11 18:38:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/920503002/1
5 years, 10 months ago (2015-02-11 18:39:25 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/528)
5 years, 10 months ago (2015-02-11 18:40:56 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/920503002/20001
5 years, 10 months ago (2015-02-15 06:24:24 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-15 06:50:07 UTC) #18
commit-bot: I haz the power
5 years, 10 months ago (2015-02-15 06:50:23 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a10ed727bcb610dab80950cc12dc5867c329d8c6
Cr-Commit-Position: refs/heads/master@{#26648}

Powered by Google App Engine
This is Rietveld 408576698