Fix a unittest that was leaking a HANDLE due to base::Process refactoring.

Fix a unittest that was leaking a HANDLE due to base::Process refactoring.

BUG=

Committed: https://crrev.com/3baa9e431a86994170deb88839517dae6e5fa6ef
Cr-Commit-Position: refs/heads/master@{#317407}

[erikwright (departed), 2015-02-12 20:06:05]

Patchset #1 (id:1) has been deleted

[erikwright (departed), 2015-02-12 20:09:28]

erikwright@chromium.org changed reviewers:
+ rvargas@chromium.org

[erikwright (departed), 2015-02-12 20:09:29]

rvargas: PTAL. Your recent change had this unittest leaking a HANDLE.

https://codereview.chromium.org/868543002

The first function under test serializes a HANDLE to a command line. It is
intended that the command line be used to launch another process that inherits
the HANDLE.

The second function is intended to deserialize the HANDLE in the second process
and take ownership of it.

Since we are operating in a single process, there is no duplication via
inheritance occurring and we must therefore take precaution to not double-free
the HANDLE.

There seems to be no means to "Take" the HANDLE from a base::Process so that
class seems not useful here in the end. And the other base:: functions that
opened process handles are gone now (understandably) so I use the Windows API
directly (in this Windows-only test).

[rvargas (doing something else), 2015-02-12 21:05:17]

lgtm

https://codereview.chromium.org/920483003/diff/20001/chrome/app/chrome_watche...
File chrome/app/chrome_watcher_command_line_unittest_win.cc (right):

https://codereview.chromium.org/920483003/diff/20001/chrome/app/chrome_watche...
chrome/app/chrome_watcher_command_line_unittest_win.cc:11: #include
"base/process/process.h"
This should not be needed anymore.

[erikwright (departed), 2015-02-20 16:52:15]

erikwright@chromium.org changed reviewers:
+ grt@chromium.org

[erikwright (departed), 2015-02-20 16:52:16]

grt: PTAL.

[erikwright (departed), 2015-02-20 16:56:07]

New patchsets have been uploaded after l-g-t-m from rvargas@chromium.org

[grt (UTC plus 2), 2015-02-20 17:46:47]

lgtm

[erikwright (departed), 2015-02-20 17:48:32]

The CQ bit was checked by erikwright@chromium.org

[commit-bot: I haz the power, 2015-02-20 17:49:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/920483003/40001

[commit-bot: I haz the power, 2015-02-20 19:35:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-20 19:35:38]

Try jobs failed on following builders:
  win8_chromium_rel on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[erikwright (departed), 2015-02-20 20:56:21]

New patchsets have been uploaded after l-g-t-m from grt@chromium.org

[erikwright (departed), 2015-02-20 20:56:32]

The CQ bit was checked by erikwright@chromium.org

[commit-bot: I haz the power, 2015-02-20 20:58:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/920483003/60001

[commit-bot: I haz the power, 2015-02-20 21:41:30]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-02-20 21:42:59]

Patchset 3 (id:??) landed as
https://crrev.com/3baa9e431a86994170deb88839517dae6e5fa6ef
Cr-Commit-Position: refs/heads/master@{#317407}