Android: SetCreateContextCallback

content/public/browser/android/synchronous_compositor.h

Index: content/public/browser/android/synchronous_compositor.h
diff --git a/content/public/browser/android/synchronous_compositor.h b/content/public/browser/android/synchronous_compositor.h
index 476b86dce8310bb235402a50a67bab4137f8fca5..2c69c15ed239228c2e25ddbb9ee6baf21adada8a 100644
--- a/content/public/browser/android/synchronous_compositor.h
+++ b/content/public/browser/android/synchronous_compositor.h
@@ -5,9 +5,11 @@
 #ifndef CONTENT_PUBLIC_BROWSER_ANDROID_SYNCHRONOUS_COMPOSITOR_H_
 #define CONTENT_PUBLIC_BROWSER_ANDROID_SYNCHRONOUS_COMPOSITOR_H_
 
+#include "base/callback.h"
 #include "base/memory/ref_counted.h"
 #include "content/common/content_export.h"
 #include "gpu/command_buffer/service/in_process_command_buffer.h"
+#include "third_party/WebKit/public/platform/WebGraphicsContext3D.h"
 #include "ui/gfx/geometry/rect.h"
 #include "ui/gfx/geometry/size.h"
 
@@ -16,14 +18,11 @@ class SkCanvas;
 namespace cc {
 class CompositorFrame;
 class CompositorFrameAck;
+class ContextProvider;
 }
 
 namespace gfx {
 class Transform;
-};
-
-namespace gpu {
-class GLInProcessContext;
 }
 
 namespace content {
@@ -41,6 +40,11 @@ class CONTENT_EXPORT SynchronousCompositor {
   static void SetClientForWebContents(WebContents* contents,
                                       SynchronousCompositorClient* client);
 
+  typedef base::Callback<
+      cc::ContextProvider(bool, blink::WebGraphicsContext3D::Attributes, bool)>
+      CreateContextCallback;

[boliu, 2015/02/11 16:52:41]

Return type should be a struct like below (since there is code that requires the
GLInProcessContext pointer):

struct ContextHolder {
  scoped_refptr<ContextProviderWebContext> context_provider;
  gpu::GLInProcessContext* context;
};

nit: blink::WebGraphicsContext3D::Attributes can be const&

And need lots of comments to explain arguments and return values.

+  static void SetCreateContextCallback(CreateContextCallback callback);
+
   static void SetGpuService(
       scoped_refptr<gpu::InProcessCommandBuffer::Service> service);