Android: SetCreateContextCallback

content/public/browser/android/synchronous_compositor.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_ANDROID_SYNCHRONOUS_COMPOSITOR_H_
 #define CONTENT_PUBLIC_BROWSER_ANDROID_SYNCHRONOUS_COMPOSITOR_H_
 
+#include "base/callback.h"
 #include "base/memory/ref_counted.h"
 #include "content/common/content_export.h"
 #include "gpu/command_buffer/service/in_process_command_buffer.h"
+#include "third_party/WebKit/public/platform/WebGraphicsContext3D.h"
 #include "ui/gfx/geometry/rect.h"
 #include "ui/gfx/geometry/size.h"
 
 class SkCanvas;
 
 namespace cc {
 class CompositorFrame;
 class CompositorFrameAck;
 }
 
+namespace cc_blink {
+class ContextProviderWebContext;
+}
+
 namespace gfx {
 class Transform;
-};
+}
 
 namespace gpu {
 class GLInProcessContext;
 }
 
 namespace content {
 
 class SynchronousCompositorClient;
 class WebContents;
 
 // Interface for embedders that wish to direct compositing operations
 // synchronously under their own control. Only meaningful when the
 // kEnableSyncrhonousRendererCompositor flag is specified.
 class CONTENT_EXPORT SynchronousCompositor {
  public:
+  struct ContextHolder {
+    ContextHolder();
+    ~ContextHolder();
+
+    scoped_refptr<cc_blink::ContextProviderWebContext> context_provider;
+    gpu::GLInProcessContext* context;
+  };
+
   // Must be called once per WebContents instance. Will create the compositor
   // instance as needed, but only if |client| is non-nullptr.
   static void SetClientForWebContents(WebContents* contents,
                                       SynchronousCompositorClient* client);
 
+  // The parameters are: |is_offscreen|, |attributes| and
+  // |need_share_group_with_parent|.

[boliu, 2015/02/17 16:50:43]

Suggest putting the parameters next to the declaration, something like:

typedef base::Callback<ContextHolder(
      bool /* need_share_group_with_parent */,
      const blink::WebGraphicsContext3D::Attributes& /* attributes */,
      bool /* is_offscreen */)>
      CreateContextCallback;

Also suggest putting need_share_group_with_parent first (it replaces the current
"scoped_refptr<gpu::InProcessCommandBuffer::Service> service" parameter which is
first).

[tfarina, 2015/02/17 16:58:18]

Done.

+  typedef base::Callback<
+      ContextHolder(bool, const blink::WebGraphicsContext3D::Attributes&, bool)>
+      CreateContextCallback;
+  static void SetCreateContextCallback(CreateContextCallback callback);
+
   static void SetGpuService(
       scoped_refptr<gpu::InProcessCommandBuffer::Service> service);
 
   // By default, synchronous compopsitor records the full layer, not only
   // what is inside and around the view port. This can be used to switch
   // between this record-full-layer behavior and normal record-around-viewport
   // behavior.
   static void SetRecordFullDocument(bool record_full_document);
 
   // Synchronously initialize compositor for hardware draw. Can only be called
@@ skipping 33 matching lines @@
   // SynchronousCompositorClient::GetTotalRootLayerScrollOffset).
   virtual void DidChangeRootLayerScrollOffset() = 0;
 
  protected:
   virtual ~SynchronousCompositor() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_ANDROID_SYNCHRONOUS_COMPOSITOR_H_