Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 920423003: Stop lieing about GrBatch color for Rects (Closed)

Created:
5 years, 10 months ago by joshua.litt
Modified:
5 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Stop lieing about GrBatch color for Rects BUG=skia: Committed: https://skia.googlesource.com/skia/+/db0f9516ae22a28e16e18bfaa375eca01d29e346

Patch Set 1 #

Patch Set 2 : more cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -76 lines) Patch
M src/gpu/GrAAConvexPathRenderer.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 1 5 chunks +12 lines, -24 lines 0 comments Download
M src/gpu/GrBatch.h View 2 chunks +2 lines, -10 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 10 chunks +0 lines, -25 lines 0 comments Download
M src/gpu/GrTestBatch.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
joshualitt
5 years, 10 months ago (2015-02-13 20:13:13 UTC) #3
bsalomon
lgtm
5 years, 10 months ago (2015-02-13 20:26:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/920423003/20001
5 years, 10 months ago (2015-02-13 20:43:46 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 20:50:13 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/db0f9516ae22a28e16e18bfaa375eca01d29e346

Powered by Google App Engine
This is Rietveld 408576698