Issue 92037: Fix linker errors on Visual Studio 2008 after the tcmalloc introduction....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 92037: Fix linker errors on Visual Studio 2008 after the tcmalloc introduction.... (Closed)

Created:
11 years, 8 months ago by Sverrir

Modified:
9 years, 7 months ago

Reviewers:
Mike Belshe, wtc

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix linker errors on Visual Studio 2008 after the tcmalloc introduction. Minor change to Mike's suggested fix. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14257

Patch Set 1 #

Total comments: 1

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -16 lines)			Patch
	M	third_party/tcmalloc/prep_libc.sh	View		1 chunk	+13 lines, -16 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sverrir

Thanks for the original file you sent me. I just added the last three files ...

11 years, 8 months ago (2009-04-22 20:41:57 UTC) #1

wtc

11 years, 8 months ago (2009-04-23 16:13:55 UTC) #3

http://codereview.chromium.org/92037/diff/1/2
File third_party/tcmalloc/prep_libc.sh (right):

http://codereview.chromium.org/92037/diff/1/2#newcode26
Line 26:
LIBCMTSRCPATHVS2008="f:\\dd\\vctools\\crt_bld\\SELF_X86\\crt\\src\\build\\INTEL\\mt_obj\\"
Is the hardcoded F: drive in the VS 2008 pathname a problem?

Expand Messages | Collapse Messages