Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 920343003: cc: Fix crash in TileTaskWorkerPoolPerfTests. (Closed)

Created:
5 years, 10 months ago by USE eero AT chromium.org
Modified:
5 years, 10 months ago
Reviewers:
hendrikw, reveman, vmiura, vmpstr
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Fix crash in TileTaskWorkerPoolPerfTests. TileTaskWorkerPoolPerfTests did not set up a GPU rasterizer. That resulted in a resource provider to be queried from a NULL rasterizer in GPU tile task work pool. This fix sets up a GPU rasterizer for TileTaskWorkerPoolPerfTests. BUG=444264, 454500 Committed: https://crrev.com/f31153ac1c030b4ccf176709afe0db2447fd6c8b Cr-Commit-Position: refs/heads/master@{#316835}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M cc/resources/tile_task_worker_pool_perftest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
USE eero AT chromium.org
PTAL. This fixes crashes in cc_perftests.
5 years, 10 months ago (2015-02-18 15:18:30 UTC) #2
vmiura
On 2015/02/18 15:18:30, e_hakkinen wrote: > PTAL. This fixes crashes in cc_perftests. LGTM. Thanks for ...
5 years, 10 months ago (2015-02-18 15:40:00 UTC) #4
reveman
lgtm
5 years, 10 months ago (2015-02-18 15:43:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/920343003/1
5 years, 10 months ago (2015-02-18 15:45:25 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-18 16:17:51 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 16:18:21 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f31153ac1c030b4ccf176709afe0db2447fd6c8b
Cr-Commit-Position: refs/heads/master@{#316835}

Powered by Google App Engine
This is Rietveld 408576698