Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 920343002: Delete Sky tests that we're not going to run with Dart (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
ojan, eseidel
CC:
ojan, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Delete Sky tests that we're not going to run with Dart This CL removes a number of tests that we don't plan to port to Dart: 1) custom-elements. We're going to use a different mechanism for custom elements. We'll need to write a new set of tests as we implement it. 2) inspector. These are tests of the JS inspector backend, which we don't plan to use. 3) js. This is a test of a JavaScript feature. 4) mocha. These are tests of the JavaScript testing framework we were using. 5) mutation-observer. We're keeping the C++ code for mutation observers, but it's unclear how we want to expose this in the platform. 6) resources. These are JavaScript-based testing frameworks. R=eseidel@chromium.org, ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f30411abfd4abee7da7350f86e872606dd1bd08e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10898 lines) Patch
M sky/tests/TestExpectations View 3 chunks +1 line, -56 lines 0 comments Download
D sky/tests/custom-elements/constructor-calls-created-synchronously.sky View 1 chunk +0 lines, -21 lines 0 comments Download
D sky/tests/custom-elements/constructor-calls-created-synchronously-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/custom-elements/document-register-basic.sky View 1 chunk +0 lines, -101 lines 0 comments Download
D sky/tests/custom-elements/document-register-basic-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/custom-elements/document-register-reentrant-null-constructor.sky View 1 chunk +0 lines, -18 lines 0 comments Download
D sky/tests/custom-elements/document-register-reentrant-null-constructor-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/tests/custom-elements/document-register-reentrant-returning-fake.sky View 1 chunk +0 lines, -21 lines 0 comments Download
D sky/tests/custom-elements/document-register-reentrant-returning-fake-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tests/custom-elements/document-register-reentrant-throwing-constructor.sky View 1 chunk +0 lines, -18 lines 0 comments Download
D sky/tests/custom-elements/document-register-reentrant-throwing-constructor-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/tests/custom-elements/element-upgrade-no-register-and-leak.sky View 1 chunk +0 lines, -13 lines 0 comments Download
D sky/tests/custom-elements/element-upgrade-no-register-and-leak-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/tests/custom-elements/generated-constructor.sky View 1 chunk +0 lines, -19 lines 0 comments Download
D sky/tests/custom-elements/generated-constructor-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/custom-elements/html-element-type-extension-assert.sky View 1 chunk +0 lines, -11 lines 0 comments Download
D sky/tests/custom-elements/html-element-type-extension-assert-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tests/custom-elements/lifecycle-created-createElement-recursion.sky View 1 chunk +0 lines, -10 lines 0 comments Download
D sky/tests/custom-elements/lifecycle-created-createElement-recursion-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/tests/custom-elements/lifecycle-created-createElement-reentrancy.sky View 1 chunk +0 lines, -29 lines 0 comments Download
D sky/tests/custom-elements/lifecycle-created-createElement-reentrancy-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tests/custom-elements/lifecycle-created-parser-script.sky View 1 chunk +0 lines, -15 lines 0 comments Download
D sky/tests/custom-elements/lifecycle-created-parser-script-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/tests/custom-elements/resources/document-register-fuzz.sky View 1 chunk +0 lines, -60 lines 0 comments Download
D sky/tests/inspector/css-computed-style.sky View 1 chunk +0 lines, -18 lines 0 comments Download
D sky/tests/inspector/css-computed-style-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tests/inspector/dom-mutation.sky View 1 chunk +0 lines, -36 lines 0 comments Download
D sky/tests/inspector/dom-mutation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tests/inspector/dom-mutation-modify-text-node-and-append.sky View 1 chunk +0 lines, -34 lines 0 comments Download
D sky/tests/inspector/dom-mutation-modify-text-node-and-append-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D sky/tests/inspector/page-agent-get-resource-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tests/inspector/page-agent-get-resource-tree.sky View 1 chunk +0 lines, -43 lines 0 comments Download
D sky/tests/inspector/page-agent-get-resource-tree-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/js/classes.sky View 1 chunk +0 lines, -163 lines 0 comments Download
D sky/tests/js/classes-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D sky/tests/mocha/describe-only.sky View 1 chunk +0 lines, -20 lines 0 comments Download
D sky/tests/mocha/describe-only-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/mocha/it-only.sky View 1 chunk +0 lines, -18 lines 0 comments Download
D sky/tests/mocha/it-only-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/mutation-observer/callback-arguments.sky View 1 chunk +0 lines, -18 lines 0 comments Download
D sky/tests/mutation-observer/callback-arguments-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/mutation-observer/clear-transient-without-delivery.sky View 1 chunk +0 lines, -28 lines 0 comments Download
D sky/tests/mutation-observer/clear-transient-without-delivery-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/mutation-observer/create-during-delivery.sky View 1 chunk +0 lines, -37 lines 0 comments Download
D sky/tests/mutation-observer/create-during-delivery-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/mutation-observer/cross-document.sky View 1 chunk +0 lines, -49 lines 0 comments Download
D sky/tests/mutation-observer/cross-document-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D sky/tests/mutation-observer/delivery-order.sky View 1 chunk +0 lines, -40 lines 0 comments Download
D sky/tests/mutation-observer/delivery-order-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/mutation-observer/disconnect-cancel-pending.sky View 1 chunk +0 lines, -44 lines 0 comments Download
D sky/tests/mutation-observer/disconnect-cancel-pending-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/mutation-observer/document-fragment-insertion.sky View 1 chunk +0 lines, -69 lines 0 comments Download
D sky/tests/mutation-observer/document-fragment-insertion-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D sky/tests/mutation-observer/mutate-during-delivery.sky View 1 chunk +0 lines, -34 lines 0 comments Download
D sky/tests/mutation-observer/mutate-during-delivery-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/mutation-observer/mutation-callback-non-element-crash.sky View 1 chunk +0 lines, -15 lines 0 comments Download
D sky/tests/mutation-observer/mutation-callback-non-element-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tests/mutation-observer/mutation-observer-constructor.sky View 1 chunk +0 lines, -28 lines 0 comments Download
D sky/tests/mutation-observer/mutation-observer-constructor-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D sky/tests/mutation-observer/mutation-record-constructor.sky View 1 chunk +0 lines, -22 lines 0 comments Download
D sky/tests/mutation-observer/mutation-record-constructor-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/mutation-observer/mutation-record-nullity.sky View 1 chunk +0 lines, -42 lines 0 comments Download
D sky/tests/mutation-observer/mutation-record-nullity-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D sky/tests/mutation-observer/observe-attributes.sky View 1 chunk +0 lines, -569 lines 0 comments Download
D sky/tests/mutation-observer/observe-attributes-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D sky/tests/mutation-observer/observe-characterdata.sky View 1 chunk +0 lines, -229 lines 0 comments Download
D sky/tests/mutation-observer/observe-characterdata-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D sky/tests/mutation-observer/observe-childList.sky View 1 chunk +0 lines, -322 lines 0 comments Download
D sky/tests/mutation-observer/observe-childList-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D sky/tests/mutation-observer/observe-exceptions.sky View 1 chunk +0 lines, -54 lines 0 comments Download
D sky/tests/mutation-observer/observe-exceptions-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/mutation-observer/observe-options-attributes.sky View 1 chunk +0 lines, -34 lines 0 comments Download
D sky/tests/mutation-observer/observe-options-attributes-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/mutation-observer/observe-options-character-data.sky View 1 chunk +0 lines, -26 lines 0 comments Download
D sky/tests/mutation-observer/observe-options-character-data-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/mutation-observer/observe-subtree.sky View 1 chunk +0 lines, -267 lines 0 comments Download
D sky/tests/mutation-observer/observe-subtree-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D sky/tests/mutation-observer/observer-wrapper-dropoff.sky View 1 chunk +0 lines, -28 lines 0 comments Download
D sky/tests/mutation-observer/observer-wrapper-dropoff-transient.sky View 1 chunk +0 lines, -29 lines 0 comments Download
D sky/tests/mutation-observer/script-append.sky View 1 chunk +0 lines, -27 lines 0 comments Download
D sky/tests/mutation-observer/script-append-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/mutation-observer/shadow-dom.sky View 1 chunk +0 lines, -40 lines 0 comments Download
D sky/tests/mutation-observer/shadow-dom-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/mutation-observer/takeRecords.sky View 1 chunk +0 lines, -53 lines 0 comments Download
D sky/tests/mutation-observer/takeRecords-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D sky/tests/mutation-observer/transient-gc-crash.sky View 1 chunk +0 lines, -22 lines 0 comments Download
D sky/tests/mutation-observer/weak-callback-gc-crash.sky View 1 chunk +0 lines, -17 lines 0 comments Download
D sky/tests/resources/chai.sky View 1 chunk +0 lines, -4784 lines 0 comments Download
D sky/tests/resources/js-test.sky View 1 chunk +0 lines, -590 lines 0 comments Download
D sky/tests/resources/mocha.sky View 1 chunk +0 lines, -2449 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
abarth-chromium
5 years, 10 months ago (2015-02-13 05:48:23 UTC) #1
abarth-chromium
5 years, 10 months ago (2015-02-13 05:48:29 UTC) #2
eseidel
lgtm
5 years, 10 months ago (2015-02-13 18:38:36 UTC) #4
ojan
lgtm
5 years, 10 months ago (2015-02-13 18:55:17 UTC) #5
abarth-chromium
5 years, 10 months ago (2015-02-13 21:51:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f30411abfd4abee7da7350f86e872606dd1bd08e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698