Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 920313003: Implement function entry breakpoints in Observatory debugger. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index fb46c10304d9e2289c62703137111807d430c6a5..ac336add2f81344431d87f32153331a0cefc30e9 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -1091,7 +1091,7 @@ class Isolate extends ServiceObjectOwner with Coverage {
Future<ServiceObject> addBreakpoint(Script script, int line) {
// TODO(turnidge): Pass line as an int instead of a string.
return invokeRpc('addBreakpoint',
- { 'script': script.id, 'line': '$line' }).then((result) {
+ { 'scriptId': script.id, 'line': '$line' }).then((result) {
if (result is ServiceMap &&
result.type == 'Breakpoint' &&
result['resolved'] &&
@@ -1108,6 +1108,17 @@ class Isolate extends ServiceObjectOwner with Coverage {
});
}
+ Future<ServiceObject> addBreakpointAtEntry(ServiceFunction function) {
+ return invokeRpc('addBreakpointAtEntry',
+ { 'functionId': function.id }).then((result) {
+ // TODO(turnidge): Instead of reloading all of the breakpoints,
+ // rely on events to update the breakpoint list.
+ return reloadBreakpoints().then((_) {
+ return result;
+ });
+ });
+ }
+
Future removeBreakpoint(ServiceMap bpt) {
return invokeRpc('removeBreakpoint',
{ 'breakpointId': bpt.id }).then((result) {

Powered by Google App Engine
This is Rietveld 408576698