Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 920223002: Replace CRLFs in Polymer source files with LFs. (Closed)

Created:
5 years, 10 months ago by michaelpg
Modified:
5 years, 10 months ago
CC:
chromium-reviews, dcheng, michaelpg+watch-polymer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace CRLFs in Polymer source files with LFs. BUG=458315 R=dzhioev@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/f42e06146b269624aaa694baa3ee19759ef21b1b Committed: https://crrev.com/f96c619a42cac552327a0f9879f07241a7ba5441 Cr-Commit-Position: refs/heads/master@{#316372}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Land whitespace changes to unblock #

Patch Set 3 : Update reproduce.sh with literal '\r' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M third_party/polymer/README.chromium View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M third_party/polymer/reproduce.sh View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (2 generated)
michaelpg
Actual changes are in README.chromium and reproduce.sh. The rest is mechanical CRLF -> LF replacements ...
5 years, 10 months ago (2015-02-12 22:42:55 UTC) #1
michaelpg
https://codereview.chromium.org/920223002/diff/1/third_party/polymer/reproduce.sh File third_party/polymer/reproduce.sh (right): https://codereview.chromium.org/920223002/diff/1/third_party/polymer/reproduce.sh#newcode29 third_party/polymer/reproduce.sh:29: Is there a better way to specify a literal ...
5 years, 10 months ago (2015-02-12 23:04:51 UTC) #2
dzhioev (left Google)
On 2015/02/12 23:04:51, michaelpg wrote: > https://codereview.chromium.org/920223002/diff/1/third_party/polymer/reproduce.sh > File third_party/polymer/reproduce.sh (right): > > https://codereview.chromium.org/920223002/diff/1/third_party/polymer/reproduce.sh#newcode29 > ...
5 years, 10 months ago (2015-02-13 11:22:20 UTC) #3
dzhioev (left Google)
On 2015/02/13 11:22:20, dzhioev wrote: > On 2015/02/12 23:04:51, michaelpg wrote: > > > https://codereview.chromium.org/920223002/diff/1/third_party/polymer/reproduce.sh ...
5 years, 10 months ago (2015-02-13 11:34:48 UTC) #4
michaelpg
On 2015/02/13 11:34:48, dzhioev wrote: > On 2015/02/13 11:22:20, dzhioev wrote: > > On 2015/02/12 ...
5 years, 10 months ago (2015-02-13 19:37:36 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f42e06146b269624aaa694baa3ee19759ef21b1b Cr-Commit-Position: refs/heads/master@{#316310}
5 years, 10 months ago (2015-02-13 22:45:47 UTC) #7
michaelpg
Committed patchset #2 (id:10001) manually as f42e06146b269624aaa694baa3ee19759ef21b1b (presubmit successful).
5 years, 10 months ago (2015-02-13 22:45:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/920223002/20001
5 years, 10 months ago (2015-02-14 03:55:58 UTC) #10
michaelpg
On 2015/02/13 19:37:36, michaelpg wrote: > On 2015/02/13 11:34:48, dzhioev wrote: > > On 2015/02/13 ...
5 years, 10 months ago (2015-02-14 03:56:42 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:20001)
5 years, 10 months ago (2015-02-14 04:33:52 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-14 04:34:47 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f96c619a42cac552327a0f9879f07241a7ba5441
Cr-Commit-Position: refs/heads/master@{#316372}

Powered by Google App Engine
This is Rietveld 408576698