Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 920173002: MIPS: new classes: no longer experimental. (Closed)

Created:
5 years, 10 months ago by akos.palfi.imgtec
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@gsub-2014-02-12-fdcf3e59ba4af1aa3c5b31a18e615169c97958ab
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: new classes: no longer experimental. Port 2707d4c9f4b6e6e600e708b3b08b09d27d594ce7 Original commit message: This CL fixes tests that no longer valid and also fixes two issues: 1. 'super()' in non derived constructors. 2. Failure to step into derived constructors. BUG= R=paul.lind@imgtec.com Committed: https://chromium.googlesource.com/v8/v8/+/db13f0847b78d59eb20c733a6ca768ea269ef65e

Patch Set 1 #

Patch Set 2 : Fix typo. #

Patch Set 3 : Fixed pop order. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -4 lines) Patch
M src/mips/builtins-mips.cc View 1 2 1 chunk +16 lines, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/builtins-mips64.cc View 1 2 1 chunk +17 lines, -1 line 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
akos.palfi.imgtec
PTAL.
5 years, 10 months ago (2015-02-12 22:05:55 UTC) #2
paul.l...
lgtm
5 years, 10 months ago (2015-02-12 23:15:18 UTC) #3
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/db13f0847b78d59eb20c733a6ca768ea269ef65e Cr-Commit-Position: refs/heads/master@{#26635}
5 years, 10 months ago (2015-02-13 01:26:26 UTC) #4
akos.palfi.imgtec
5 years, 10 months ago (2015-02-13 01:26:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
db13f0847b78d59eb20c733a6ca768ea269ef65e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698