Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issue 920153002: Disable the Notification JavaScript constructor for Android. (Closed)

Created:
5 years, 10 months ago by Peter Beverloo
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable the Notification JavaScript constructor for Android. Android won't be able to support this reliably, and hasn't yet shipped this feature, so this is the time to take it out. This is part of a two-sided patch: [1] https://codereview.chromium.org/901843006 [2] This patch. BUG=441828 Committed: https://crrev.com/26573cf57a68687ed3623d8ebd98e32cb6e7f251 Cr-Commit-Position: refs/heads/master@{#316572}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/child/runtime_features.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Peter Beverloo
+mkwst for the flag (depending on other review) +avi for content/child/runtime_features.cc Sorry to have to ...
5 years, 10 months ago (2015-02-12 21:41:15 UTC) #2
Avi (use Gerrit)
lgtm
5 years, 10 months ago (2015-02-12 21:43:34 UTC) #3
Mike West
On 2015/02/12 at 21:43:34, avi wrote: > lgtm LGTM. I wouldn't mind you landing the ...
5 years, 10 months ago (2015-02-13 04:53:30 UTC) #4
Peter Beverloo
On 2015/02/13 04:53:30, Mike West wrote: > On 2015/02/12 at 21:43:34, avi wrote: > > ...
5 years, 10 months ago (2015-02-17 12:29:59 UTC) #5
Mike West
Yup. Land it.
5 years, 10 months ago (2015-02-17 12:31:33 UTC) #6
Peter Beverloo
On 2015/02/17 12:31:33, Mike West wrote: > Yup. Land it. Cool, thanks!
5 years, 10 months ago (2015-02-17 12:36:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/920153002/1
5 years, 10 months ago (2015-02-17 12:36:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 14:06:55 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 14:07:46 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/26573cf57a68687ed3623d8ebd98e32cb6e7f251
Cr-Commit-Position: refs/heads/master@{#316572}

Powered by Google App Engine
This is Rietveld 408576698