Add getCallSiteData to the VM service.

runtime/vm/service.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/service.h"
 
 #include "include/dart_api.h"
 #include "platform/globals.h"
 
 #include "vm/compiler.h"
@@ skipping 1470 matching lines @@
     result.PrintJSON(js, true);
     return true;
   }
   PrintError(js, "%s: Invalid 'targetId' parameter value: "
              "id '%s' does not correspond to a "
              "library, class, or instance", js->method(), target_id);
   return true;
 }
 
 
+static const MethodParameter* get_call_site_data_params[] = {
+  ISOLATE_PARAMETER,
+  NULL,

[Cutch, 2015/02/12 20:38:02]

Should be:

ISOLATE_PARAMETER,
new IdParameter("targetId", true)",
NULL,

[rmacnak, 2015/02/12 20:55:12]

Done.

+};
+
+
+static bool HandleIsolateGetCallSiteData(Isolate* isolate, JSONStream* js) {
+  const char* target_id = js->LookupParam("targetId");
+  Object& obj = Object::Handle(LookupHeapObject(isolate, target_id, NULL));
+  if (obj.raw() == Object::sentinel().raw()) {
+    PrintInvalidParamError(js, "targetId");
+    return true;
+  }
+  if (obj.IsFunction()) {
+    const Function& func = Function::Cast(obj);
+    const GrowableObjectArray& ics =
+        GrowableObjectArray::Handle(func.CollectICsWithSourcePositions());
+    JSONObject jsobj(js);
+    jsobj.AddProperty("type", "CallSiteData");

[Cutch, 2015/02/12 20:38:02]

If this isn't guaranteed to be stable across VM versions prefix the type with an
underscore. That is: "_CallSiteData".

[rmacnak, 2015/02/12 20:55:12]

Good idea for a first cut.

+    jsobj.AddProperty("function", func);
+    JSONArray elements(&jsobj, "callSites");
+    Smi& line = Smi::Handle();
+    Smi& column = Smi::Handle();
+    ICData& ic_data = ICData::Handle();
+    for (intptr_t i = 0; i < ics.Length();) {
+      ic_data ^= ics.At(i++);
+      line ^= ics.At(i++);
+      column ^= ics.At(i++);
+      ic_data.PrintToJSONArray(&elements, line.Value(), column.Value());
+    }
+    return true;
+  }
+  return false;
+}
+
+
 class GetInstancesVisitor : public ObjectGraph::Visitor {
  public:
   GetInstancesVisitor(const Class& cls, const Array& storage)
       : cls_(cls), storage_(storage), count_(0) {}
 
   virtual Direction VisitObject(ObjectGraph::StackIterator* it) {
     RawObject* raw_obj = it->Get();
     if (raw_obj->IsFreeListElement()) {
       return kProceed;
     }
@@ skipping 911 matching lines @@
   { "_triggerEchoEvent", HandleIsolateTriggerEchoEvent,
     NULL },
   { "addBreakpoint", HandleIsolateAddBreakpoint,
     add_breakpoint_params },
   { "eval", HandleIsolateEval,
     eval_params },
   { "getAllocationProfile", HandleIsolateGetAllocationProfile,
     get_allocation_profile_params },
   { "getBreakpoints", HandleIsolateGetBreakpoints,
     get_breakpoints_params },
+  { "getCallSiteData", HandleIsolateGetCallSiteData,

[Cutch, 2015/02/12 20:38:02]

Please add this to service.idl

[rmacnak, 2015/02/12 20:55:12]

Done.

+    get_call_site_data_params },
   { "getClassList", HandleIsolateGetClassList,
     get_class_list_params },
   { "getCoverage", HandleIsolateGetCoverage,
     get_coverage_params },
   { "getCpuProfile", HandleIsolateGetCpuProfile,
     get_cpu_profile_params },
   { "getFlagList", HandleVMFlagList ,
     get_flag_list_params },
   { "getHeapMap", HandleIsolateGetHeapMap,
     get_heap_map_params },
@@ skipping 47 matching lines @@
     ServiceMethodDescriptor& method = service_methods_[i];
     if (strcmp(method_name, method.name) == 0) {
       return &method;
     }
   }
   return NULL;
 }
 
 
 }  // namespace dart