Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1652)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContents.java

Issue 920083002: Move detachGLFunctor call before hardware teardown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/java/src/org/chromium/android_webview/AwContents.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwContents.java b/android_webview/java/src/org/chromium/android_webview/AwContents.java
index e124eb5583574a04ce8d1f3712682f37aa00133a..7d4009a6c286f87ce503714faeddba2b890ad970 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwContents.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwContents.java
@@ -2561,6 +2561,8 @@ public class AwContents implements SmartClipProvider {
Log.w(TAG, "onDetachedFromWindow called when already detached. Ignoring");
return;
}
+ mNativeGLDelegate.detachGLFunctor();
boliu 2015/02/12 19:42:43 As discussed, this should be moved to invalidateOn
boliu 2015/02/13 01:33:28 Since we might want to cherry-pick this back, do t
+
mIsAttachedToWindow = false;
hideAutofillPopup();
nativeOnDetachedFromWindow(mNativeAwContents);
@@ -2574,7 +2576,6 @@ public class AwContents implements SmartClipProvider {
}
mScrollAccessibilityHelper.removePostedCallbacks();
- mNativeGLDelegate.detachGLFunctor();
}
@Override
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698