Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 920083002: Move detachGLFunctor call before hardware teardown. (Closed)

Created:
5 years, 10 months ago by Tobias Sargeant
Modified:
5 years, 10 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move detachGLFunctor call before hardware teardown. By not detaching the GL functor until after the teardown, we ran the risk of stray draw calls occurring that could potentially reinitialize the hardware renderer, causing the SharedRendererState destructor to DCHECK. BUG= Committed: https://crrev.com/4849f0cb5c59d1dc50a88803b8ca052f66f218ec Cr-Commit-Position: refs/heads/master@{#316222}

Patch Set 1 #

Total comments: 2

Patch Set 2 : move to invalidateOnFunctorDestroy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (4 generated)
Tobias Sargeant
5 years, 10 months ago (2015-02-12 17:47:34 UTC) #2
boliu
https://codereview.chromium.org/920083002/diff/1/android_webview/java/src/org/chromium/android_webview/AwContents.java File android_webview/java/src/org/chromium/android_webview/AwContents.java (right): https://codereview.chromium.org/920083002/diff/1/android_webview/java/src/org/chromium/android_webview/AwContents.java#newcode2564 android_webview/java/src/org/chromium/android_webview/AwContents.java:2564: mNativeGLDelegate.detachGLFunctor(); As discussed, this should be moved to invalidateOnFunctorDestroy. ...
5 years, 10 months ago (2015-02-12 19:42:44 UTC) #3
boliu
https://codereview.chromium.org/920083002/diff/1/android_webview/java/src/org/chromium/android_webview/AwContents.java File android_webview/java/src/org/chromium/android_webview/AwContents.java (right): https://codereview.chromium.org/920083002/diff/1/android_webview/java/src/org/chromium/android_webview/AwContents.java#newcode2564 android_webview/java/src/org/chromium/android_webview/AwContents.java:2564: mNativeGLDelegate.detachGLFunctor(); On 2015/02/12 19:42:43, boliu wrote: > As discussed, ...
5 years, 10 months ago (2015-02-13 01:33:28 UTC) #4
Tobias Sargeant
moved.
5 years, 10 months ago (2015-02-13 10:14:12 UTC) #5
boliu
lgtm
5 years, 10 months ago (2015-02-13 14:39:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/920083002/20001
5 years, 10 months ago (2015-02-13 14:46:49 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/47129)
5 years, 10 months ago (2015-02-13 15:15:47 UTC) #10
boliu
On 2015/02/13 15:15:47, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 10 months ago (2015-02-13 15:48:18 UTC) #11
boliu
On 2015/02/13 15:48:18, boliu wrote: > On 2015/02/13 15:15:47, I haz the power (commit-bot) wrote: ...
5 years, 10 months ago (2015-02-13 16:05:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/920083002/20001
5 years, 10 months ago (2015-02-13 16:08:10 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-13 16:08:49 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 16:09:22 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4849f0cb5c59d1dc50a88803b8ca052f66f218ec
Cr-Commit-Position: refs/heads/master@{#316222}

Powered by Google App Engine
This is Rietveld 408576698