Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 920063002: Fix surface crash. (Closed)

Created:
5 years, 10 months ago by qsr
Modified:
5 years, 10 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@background_crash_takes3
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix surface crash. When the surface app is asked to destroy the surface associated with the current display, it didn't notify the display, which will crash if the display schedules a draw before being reassociated with a surface. This fixes this by resetting the display that it isn't associated with a surface anymore. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/bd5de96d715d4d2ade0696c8fccc699bbd766d52

Patch Set 1 #

Patch Set 2 : Delete display instead of resetting the id. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M services/surfaces/surfaces_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M services/surfaces/surfaces_impl.cc View 1 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
qsr
James, can you confirm this is the right fix. Otherwise, what should I be doing? ...
5 years, 10 months ago (2015-02-12 16:11:42 UTC) #1
qsr
Hum, just notifying the display doesn't work when the context is then changed, because the ...
5 years, 10 months ago (2015-02-12 16:42:13 UTC) #2
jamesr
This seems fine. We really should have mojom interface for manipulating the Display as an ...
5 years, 10 months ago (2015-02-12 18:27:22 UTC) #3
jamesr
lgtm
5 years, 10 months ago (2015-02-12 18:33:58 UTC) #4
qsr
5 years, 10 months ago (2015-02-13 14:23:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
bd5de96d715d4d2ade0696c8fccc699bbd766d52 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698