Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 920043002: Remove references to 'libpeer_allocator_shim' gyp variable. This variable isn't used anymore. I'll… (Closed)

Created:
5 years, 10 months ago by tommi (sloooow) - chröme
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove references to 'libpeer_allocator_shim' gyp variable. This variable isn't used anymore. I'll delete the source files in an upcoming cl. R=kjellander@chromium.org BUG=446865 Committed: https://crrev.com/07901ab6c6d3e3dfc2e6fc861de0b7094323d2e6 Cr-Commit-Position: refs/heads/master@{#316383}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M third_party/libjingle/libjingle.gyp View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
tommi (sloooow) - chröme
5 years, 10 months ago (2015-02-12 14:14:29 UTC) #1
kjellander_chromium
lgtm, but why not delete the sources in the same CL?
5 years, 10 months ago (2015-02-12 14:21:04 UTC) #2
tommi (sloooow) - chröme
On 2015/02/12 14:21:04, kjellander wrote: > lgtm, but why not delete the sources in the ...
5 years, 10 months ago (2015-02-12 14:24:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/920043002/1
5 years, 10 months ago (2015-02-14 10:45:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-14 10:47:57 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-14 10:48:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07901ab6c6d3e3dfc2e6fc861de0b7094323d2e6
Cr-Commit-Position: refs/heads/master@{#316383}

Powered by Google App Engine
This is Rietveld 408576698