CPUProfiler: Push deopt reason further to ProfileNode.

src/deoptimizer.h

Index: src/deoptimizer.h
diff --git a/src/deoptimizer.h b/src/deoptimizer.h
index 35c3cbe66c49a7517fbf87f9c1779ede62f5192c..e48848a4755263c38f212e024208266499607689 100644
--- a/src/deoptimizer.h
+++ b/src/deoptimizer.h
@@ -188,14 +188,6 @@ class Deoptimizer : public Malloced {
     DeoptInfo(int r, const char* m, DeoptReason d)
         : raw_position(r), mnemonic(m), deopt_reason(d) {}
 
-    bool operator==(const DeoptInfo& other) const {
-      return raw_position == other.raw_position &&
-             CStringEquals(mnemonic, other.mnemonic) &&
-             deopt_reason == other.deopt_reason;
-    }
-
-    bool operator!=(const DeoptInfo& other) const { return !(*this == other); }
-
     int raw_position;
     const char* mnemonic;
     DeoptReason deopt_reason;
@@ -214,8 +206,7 @@ class Deoptimizer : public Malloced {
 
     bool IsEquivalentTo(const JumpTableEntry& other) const {
       return address == other.address && bailout_type == other.bailout_type &&
-             needs_frame == other.needs_frame &&
-             (!FLAG_trace_deopt || deopt_info == other.deopt_info);

[Sven Panne, 2015/02/12 08:42:31]

Why has this been removed? In earlier versions we needed this to distinguish
deopt reasons for the same ID, which would otherwise be merged. How is this
handled now?

[loislo, 2015/02/12 08:54:05]

I need to push different entries if FLAG_trace_deopt is True or cpu profiler is
active. For the second check I need a pointer to isolate. Also such kind of
checks looks artificial here so I decided to move it to the callers. So I do
this check in lithium-codegen-*.cc. From the other hand if we have trace_deopt
or profiler flags enabled then we don't need to compare deopt_info in assumption
that we never push deopt_info with the same reason, bailout_id and location
twice in a row.

+             needs_frame == other.needs_frame;
     }
 
     Label label;