CPUProfiler: Push deopt reason further to ProfileNode.

test/cctest/test-cpu-profiler.cc

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1702 matching lines @@
   v8::CpuProfile* outer_profile = profiler->StopProfiling(outer);
   CHECK(outer_profile);
   CHECK_EQ(1, iprofiler->GetProfilesCount());
   outer_profile->Delete();
   outer_profile = NULL;
   CHECK_EQ(0, iprofiler->GetProfilesCount());
 }
 
 
 static const char* collect_deopt_events_test_source =
-    "function opt_function(value) {\n"
-    "  return value / 10;\n"
+    "function opt_function(left, right) {\n"
+    "  var k = left / 10;\n"
+    "  var r = 10 / right;\n"
+    "  return k + r;"
     "}\n"
     "\n"
-    "function test(value) {\n"
-    "  return opt_function(value);\n"
+    "function test(left, right) {\n"
+    "  return opt_function(left, right);\n"
     "}\n"
     "\n"
     "startProfiling();\n"
     "\n"
-    "for (var i = 0; i < 10; ++i) test(10);\n"
+    "test(10, 10);\n"
     "\n"
     "%OptimizeFunctionOnNextCall(opt_function)\n"
     "\n"
-    "for (var i = 0; i < 10; ++i) test(10);\n"
+    "test(10, 10);\n"
     "\n"
-    "for (var i = 0; i < 10; ++i) test(undefined);\n"
+    "test(undefined, 10);\n"
+    "\n"
+    "%OptimizeFunctionOnNextCall(opt_function)\n"
+    "\n"
+    "test(10, 10);\n"
+    "\n"
+    "test(10, 0);\n"
     "\n"
     "stopProfiling();\n"
     "\n";
 
 
 TEST(CollectDeoptEvents) {
   if (!CcTest::i_isolate()->use_crankshaft() || i::FLAG_always_opt) return;
   i::FLAG_allow_natives_syntax = true;
   v8::HandleScope scope(CcTest::isolate());
   v8::Local<v8::Context> env = CcTest::NewContext(PROFILER_EXTENSION);
   v8::Context::Scope context_scope(env);
   v8::Isolate* isolate = env->GetIsolate();
   v8::CpuProfiler* profiler = isolate->GetCpuProfiler();
   i::CpuProfiler* iprofiler = reinterpret_cast<i::CpuProfiler*>(profiler);
 
   v8::Script::Compile(v8_str(collect_deopt_events_test_source))->Run();
   i::CpuProfile* iprofile = iprofiler->GetProfile(0);
   iprofile->Print();
   v8::CpuProfile* profile = reinterpret_cast<v8::CpuProfile*>(iprofile);
   const char* branch[] = {"", "test", "opt_function"};
   const v8::CpuProfileNode* opt_function = GetSimpleBranch(
       env->GetIsolate(), profile->GetTopDownRoot(), branch, arraysize(branch));
   CHECK(opt_function);
+  const i::ProfileNode* iopt_function =
+      reinterpret_cast<const i::ProfileNode*>(opt_function);
+  CHECK_EQ(2, iopt_function->deopt_infos().length());

[alph, 2015/02/12 13:19:46]

can you also check the reasons and positions please?

[loislo, 2015/02/12 15:20:01]

Done.

   iprofiler->DeleteProfile(iprofile);
 }