CPUProfiler: Push deopt reason further to ProfileNode.

src/deoptimizer.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_DEOPTIMIZER_H_
 #define V8_DEOPTIMIZER_H_
 
 #include "src/v8.h"
 
 #include "src/allocation.h"
@@ skipping 170 matching lines @@
     DEOPT_MESSAGES_LIST(DEOPT_MESSAGES_CONSTANTS) kLastDeoptReason
   };
 #undef DEOPT_MESSAGES_CONSTANTS
 
   static const char* GetDeoptReason(DeoptReason deopt_reason);
 
   struct DeoptInfo {
     DeoptInfo(int r, const char* m, DeoptReason d)
         : raw_position(r), mnemonic(m), deopt_reason(d) {}
 
-    bool operator==(const DeoptInfo& other) const {
-      return raw_position == other.raw_position &&
-             CStringEquals(mnemonic, other.mnemonic) &&
-             deopt_reason == other.deopt_reason;
-    }
-
-    bool operator!=(const DeoptInfo& other) const { return !(*this == other); }
-
     int raw_position;
     const char* mnemonic;
     DeoptReason deopt_reason;
   };
 
   static DeoptInfo GetDeoptInfo(Code* code, int bailout_id);
 
   struct JumpTableEntry : public ZoneObject {
     inline JumpTableEntry(Address entry, const DeoptInfo& deopt_info,
                           Deoptimizer::BailoutType type, bool frame)
         : label(),
           address(entry),
           deopt_info(deopt_info),
           bailout_type(type),
           needs_frame(frame) {}
 
     bool IsEquivalentTo(const JumpTableEntry& other) const {
       return address == other.address && bailout_type == other.bailout_type &&
-             needs_frame == other.needs_frame &&
-             (!FLAG_trace_deopt || deopt_info == other.deopt_info);

[Sven Panne, 2015/02/12 08:42:31]

Why has this been removed? In earlier versions we needed this to distinguish
deopt reasons for the same ID, which would otherwise be merged. How is this
handled now?

[loislo, 2015/02/12 08:54:05]

I need to push different entries if FLAG_trace_deopt is True or cpu profiler is
active. For the second check I need a pointer to isolate. Also such kind of
checks looks artificial here so I decided to move it to the callers. So I do
this check in lithium-codegen-*.cc. From the other hand if we have trace_deopt
or profiler flags enabled then we don't need to compare deopt_info in assumption
that we never push deopt_info with the same reason, bailout_id and location
twice in a row.

+             needs_frame == other.needs_frame;
     }
 
     Label label;
     Address address;
     DeoptInfo deopt_info;
     Deoptimizer::BailoutType bailout_type;
     bool needs_frame;
   };
 
   static bool TraceEnabledFor(BailoutType deopt_type,
@@ skipping 837 matching lines @@
   Object** parameters_;
   Object** expression_stack_;
   int source_position_;
 
   friend class Deoptimizer;
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_DEOPTIMIZER_H_