Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 919943002: Remove extensions::ServiceRegistrationManager. (Closed)

Created:
5 years, 10 months ago by Sam McNally
Modified:
5 years, 10 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, chromium-apps-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove extensions::ServiceRegistrationManager. Committed: https://crrev.com/143f3c531ee479be7f4ca61f9614de0850ef04a4 Cr-Commit-Position: refs/heads/master@{#316197}

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -301 lines) Patch
M extensions/browser/api/serial/serial_apitest.cc View 3 chunks +10 lines, -6 lines 0 comments Download
A extensions/browser/api/serial/serial_service_factory.h View 1 chunk +22 lines, -0 lines 0 comments Download
A extensions/browser/api/serial/serial_service_factory.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M extensions/browser/extension_web_contents_observer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/browser/extension_web_contents_observer.cc View 3 chunks +6 lines, -6 lines 0 comments Download
A extensions/browser/mojo/service_registration.h View 1 chunk +18 lines, -0 lines 0 comments Download
A extensions/browser/mojo/service_registration.cc View 1 chunk +79 lines, -0 lines 0 comments Download
D extensions/browser/mojo/service_registration_manager.h View 1 chunk +0 lines, -112 lines 0 comments Download
D extensions/browser/mojo/service_registration_manager.cc View 1 chunk +0 lines, -98 lines 0 comments Download
M extensions/extensions.gypi View 1 3 chunks +4 lines, -4 lines 0 comments Download
D extensions/test/test_service_registration_manager.h View 1 chunk +0 lines, -46 lines 0 comments Download
D extensions/test/test_service_registration_manager.cc View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Sam McNally
5 years, 10 months ago (2015-02-12 07:32:47 UTC) #4
Ken Rockot(use gerrit already)
lgtm Patch failures are due to the fact that source lists have moved into extensions.gypi ...
5 years, 10 months ago (2015-02-13 02:38:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/919943002/60001
5 years, 10 months ago (2015-02-13 09:05:03 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 10 months ago (2015-02-13 09:42:44 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 09:43:17 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/143f3c531ee479be7f4ca61f9614de0850ef04a4
Cr-Commit-Position: refs/heads/master@{#316197}

Powered by Google App Engine
This is Rietveld 408576698