Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 919783002: Make null GL context use callback to make current (Closed)

Created:
5 years, 10 months ago by bsalomon
Modified:
5 years, 10 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org, vmiura1
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make null GL context use callback to make current Committed: https://skia.googlesource.com/skia/+/3740972d02ed813f61fcddef9334631a9568acae

Patch Set 1 #

Patch Set 2 : minor #

Patch Set 3 : minor #

Total comments: 1

Patch Set 4 : struct- #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -23 lines) Patch
M include/gpu/gl/SkNullGLContext.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/SkNullGLContext.cpp View 1 2 3 6 chunks +37 lines, -22 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bsalomon
5 years, 10 months ago (2015-02-11 21:35:50 UTC) #2
bsalomon
5 years, 10 months ago (2015-02-11 21:36:08 UTC) #3
robertphillips
lgtm https://codereview.chromium.org/919783002/diff/40001/src/gpu/gl/SkNullGLContext.cpp File src/gpu/gl/SkNullGLContext.cpp (right): https://codereview.chromium.org/919783002/diff/40001/src/gpu/gl/SkNullGLContext.cpp#newcode117 src/gpu/gl/SkNullGLContext.cpp:117: */ I think this guy may have earned ...
5 years, 10 months ago (2015-02-11 21:54:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/919783002/60001
5 years, 10 months ago (2015-02-11 22:13:36 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 22:19:21 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/3740972d02ed813f61fcddef9334631a9568acae

Powered by Google App Engine
This is Rietveld 408576698