Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3792)

Unified Diff: appengine/chromium_build/tests/console_test.py

Issue 919733003: Fix another source of utf8 characters being lost. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/chromium_build/tests/console_test.py
diff --git a/appengine/chromium_build/tests/console_test.py b/appengine/chromium_build/tests/console_test.py
index 8de7a87960976e2cbdbafa55b2bdb983091fddfc..5a38b7bad01c4cc0ca6d76787a3d503597e99deb 100644
--- a/appengine/chromium_build/tests/console_test.py
+++ b/appengine/chromium_build/tests/console_test.py
@@ -182,3 +182,31 @@ class ConsoleTestCase(cb.CbTestCase):
self.assertEquals(self.read_file('exp_merged.html'), act_merged,
'Unexpected console output found')
+
+ def test_console_utf8_devcomment(self):
+ """Test that a console DevComment row with a UTF-8 character is retained."""
+ for master in ['mac']:
+ page_data = {'content': self.read_file('in_%s.html' % master)}
+ app.parse_master(
+ localpath='chromium.%s/console' % master,
+ remoteurl='http://build.chromium.org/p/chromium.%s/console' % master,
+ page_data=page_data)
+
+ # Get the expected and real output, compare.
+ app.console_merger(
+ 'chromium/console', '', {},
+ masters_to_merge=[
+ 'chromium.mac',
+ ],
+ num_rows_to_merge=20)
+ act_merged = app.get_and_cache_pagedata('chromium/console')['content']
+
+ # Uncomment if deeper inspection is needed of the returned console.
+ # import logging
+ # logging.debug('foo')
+ # self.write_file('exp_merged.html', act_merged.encode('utf-8'))
+ # import code
+ # code.interact(local=locals())
+
+ self.assertEquals(self.read_file('exp_merged.html').decode('utf-8'),
+ act_merged, 'Unexpected console output found')

Powered by Google App Engine
This is Rietveld 408576698