Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 919733003: Fix another source of utf8 characters being lost. (Closed)

Created:
5 years, 10 months ago by cmp
Modified:
5 years, 10 months ago
Reviewers:
jrobbins
CC:
agable, chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Fix another source of utf8 characters being lost. Add test that captures that utf8 bug. Also catch a case of extra-unicoding which was confusing the DTD spec. Thanks to jrobbins for pointing out the bad expected output. Fixing this also fixed a similar issue in test_console_merger and test_console_merger_splitrevs. R=jrobbins@chromium.org Committed: https://chromium.googlesource.com/infra/infra/+/d3af803086c10834aea14a758343315bd470a304

Patch Set 1 #

Total comments: 5

Patch Set 2 : fix extra-unicoding #

Patch Set 3 : rename vars to make clearer #

Total comments: 3

Messages

Total messages: 12 (3 generated)
cmp
Found another path in the code that was causing utf-8 strings to be down-converted to ...
5 years, 10 months ago (2015-02-12 01:24:54 UTC) #1
cmp
agable is OOO. Jason, can you review this?
5 years, 10 months ago (2015-02-12 17:45:14 UTC) #3
jrobbins
lgtm with nits/questions. https://codereview.chromium.org/919733003/diff/1/appengine/chromium_build/app.py File appengine/chromium_build/app.py (right): https://codereview.chromium.org/919733003/diff/1/appengine/chromium_build/app.py#newcode672 appengine/chromium_build/app.py:672: def utf8_convert(bstag): What does 'bstag' stand ...
5 years, 10 months ago (2015-02-12 17:55:32 UTC) #4
cmp
https://codereview.chromium.org/919733003/diff/1/appengine/chromium_build/app.py File appengine/chromium_build/app.py (right): https://codereview.chromium.org/919733003/diff/1/appengine/chromium_build/app.py#newcode672 appengine/chromium_build/app.py:672: def utf8_convert(bstag): On 2015/02/12 17:55:31, Jason Robbins wrote: > ...
5 years, 10 months ago (2015-02-12 17:59:58 UTC) #5
cmp
Now that issue is fixed plus some other places where it had snuck in. PTAL.
5 years, 10 months ago (2015-02-12 18:23:44 UTC) #7
jrobbins
lgtm
5 years, 10 months ago (2015-02-12 18:36:01 UTC) #8
cmp
Just publishing notes about this for posterity. https://codereview.chromium.org/919733003/diff/40001/appengine/chromium_build/app.py File appengine/chromium_build/app.py (left): https://codereview.chromium.org/919733003/diff/40001/appengine/chromium_build/app.py#oldcode302 appengine/chromium_build/app.py:302: for content ...
5 years, 10 months ago (2015-02-12 18:37:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/919733003/40001
5 years, 10 months ago (2015-02-12 18:38:10 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 18:40:56 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/d3af803086c10834aea14a7583433...

Powered by Google App Engine
This is Rietveld 408576698