WIP: Implement ES6 Spread-calls

src/compiler/ast-graph-builder.cc

Index: src/compiler/ast-graph-builder.cc
diff --git a/src/compiler/ast-graph-builder.cc b/src/compiler/ast-graph-builder.cc
index 50216a766c074ec10c30872e6cf9f842288101ac..bf2286b9496871496d7831a11ecfd2967b23b3c8 100644
--- a/src/compiler/ast-graph-builder.cc
+++ b/src/compiler/ast-graph-builder.cc
@@ -2225,6 +2225,20 @@ void AstGraphBuilder::VisitCompareOperation(CompareOperation* expr) {
 }
 
 
+void AstGraphBuilder::VisitSpreadOperation(SpreadOperation* expr) {
+  LoopBuilder for_loop(this);
+  VisitForEffect(expr->assign_iterator());
+  for_loop.BeginLoop(NULL, false);
+  VisitForEffect(expr->next_result());
+  VisitForTest(expr->result_done());
+  Node* condition = environment()->Pop();
+  for_loop.BreakWhen(condition);
+  VisitForValue(expr->result_value());

[Michael Starzinger, 2015/02/16 19:58:58]

I am not sure how this is supposed to work in the end. But if I understand
correctly then the operand stack size in full-codegen is not statically known
within the loop, because each iteration over the loop pushes one element in the
operand stack.

In TurboFan (as well as in Crankshaft for that matter) the environment is a
static simulation of the operand stack (similar to an abstract interpretation).
But here the operand stack cannot be simulated.

[caitp (gmail), 2015/02/16 21:41:51]

I don't think I ever finished the AstGraphBuilder portion, so I wouldn't pay
much attention to it, it probably doesn't make sense.

for now, maybe it makes more sense to just desugar spread calls into
Function.apply() as suggested previously.

+  for_loop.EndBody();
+  for_loop.EndLoop();
+}
+
+
 void AstGraphBuilder::VisitThisFunction(ThisFunction* expr) {
   Node* value = GetFunctionClosure();
   ast_context()->ProduceValue(value);