src/parser.cc - Issue 919703003: WIP: Implement ES6 Spread-calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parser.cc

Issue 919703003: WIP: Implement ES6 Spread-calls (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: AssignmentExpressions are not spreadable, add cctests for parsing Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/parser.cc

diff --git a/src/parser.cc b/src/parser.cc

index 15ed6ded0e8e08b417b1f6a7ebbe2c2f63240844..9fc8c992b5c0b7f2d0b26442eab906f13c72b913 100644

--- a/src/parser.cc

+++ b/src/parser.cc

@@ -736,14 +736,7 @@ Expression* ParserTraits::ExpressionFromString(int pos, Scanner* scanner,

Expression* ParserTraits::GetIterator(Expression* iterable,

AstNodeFactory* factory) {

- Expression* iterator_symbol_literal =

- factory->NewSymbolLiteral("iterator_symbol", RelocInfo::kNoPosition);

- int pos = iterable->position();

- Expression* prop =

- factory->NewProperty(iterable, iterator_symbol_literal, pos);

- Zone* zone = parser_->zone();

- ZoneList<Expression*>* args = new (zone) ZoneList<Expression*>(0, zone);

- return factory->NewCall(prop, args, pos);

+ return factory->GetIterator(iterable);

}