src/ast-numbering.cc - Issue 919703003: WIP: Implement ES6 Spread-calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast-numbering.cc

Issue 919703003: WIP: Implement ES6 Spread-calls (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: AssignmentExpressions are not spreadable, add cctests for parsing Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ast-numbering.cc

diff --git a/src/ast-numbering.cc b/src/ast-numbering.cc

index a2bc65827d9ded4afdc131c0467d2dab6d0006f4..f9dffd2176c5cde44947d2731bd7b6dc4eab90fb 100644

--- a/src/ast-numbering.cc

+++ b/src/ast-numbering.cc

@@ -365,6 +365,16 @@ void AstNumberingVisitor::VisitCompareOperation(CompareOperation* node) {

}

+void AstNumberingVisitor::VisitSpreadOperation(SpreadOperation* node) {

+ IncrementNodeCount();

+ node->set_base_id(ReserveIdRange(SpreadOperation::num_ids()));

+ Visit(node->assign_iterator());

+ Visit(node->next_result());

+ Visit(node->result_done());

+ Visit(node->result_value());

void AstNumberingVisitor::VisitForInStatement(ForInStatement* node) {

IncrementNodeCount();

DisableSelfOptimization();