Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Issue 919693007: Specs: Implement the Dispatcher classes. (Closed)

Created:
5 years, 10 months ago by Hixie
Modified:
5 years, 10 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 8

Patch Set 2 : Fix adam's review comments, remove @nonnull since it makes the code ugly and is unlikely to become … #

Patch Set 3 : Fix the 'extends Object with' issue. #

Patch Set 4 : add zone support #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -34 lines) Patch
M sky/specs/events.md View 1 2 3 4 chunks +109 lines, -4 lines 0 comments Download
M sky/specs/script.md View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
abarth-chromium
lgtm https://codereview.chromium.org/919693007/diff/1/sky/specs/events.md File sky/specs/events.md (right): https://codereview.chromium.org/919693007/diff/1/sky/specs/events.md#newcode18 sky/specs/events.md:18: class ExceptionListException<T> extends Object with IterableMixin<ExceptionAndStackTrace<T>> implements Exception ...
5 years, 10 months ago (2015-02-12 00:28:13 UTC) #2
Hixie
https://codereview.chromium.org/919693007/diff/1/sky/specs/events.md File sky/specs/events.md (right): https://codereview.chromium.org/919693007/diff/1/sky/specs/events.md#newcode18 sky/specs/events.md:18: class ExceptionListException<T> extends Object with IterableMixin<ExceptionAndStackTrace<T>> implements Exception { ...
5 years, 10 months ago (2015-02-12 21:31:43 UTC) #4
Hixie
Committed patchset #4 (id:60001) manually as 6311f95931f357fe9f17d19912067beede1e6e94 (presubmit successful).
5 years, 10 months ago (2015-02-12 21:40:39 UTC) #5
Hixie
5 years, 10 months ago (2015-02-12 21:41:55 UTC) #6
Message was sent while issue was closed.
By the way I have a basic VM-level unit test for some of the top part of the
events.md code (the Dispatcher stuff). Not yet checked in. Let me know when
there's somewhere useful to put it.

Powered by Google App Engine
This is Rietveld 408576698