Specs: Implement the Dispatcher classes.

Specs: Implement the Dispatcher classes.

R=abarth@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/6311f95931f357fe9f17d19912067beede1e6e94

[abarth-chromium, 2015-02-12 00:28:12]

abarth@chromium.org changed reviewers:
+ abarth@chromium.org

[abarth-chromium, 2015-02-12 00:28:13]

lgtm

https://codereview.chromium.org/919693007/diff/1/sky/specs/events.md
File sky/specs/events.md (right):

https://codereview.chromium.org/919693007/diff/1/sky/specs/events.md#newcode18
sky/specs/events.md:18: class ExceptionListException<T> extends Object with
IterableMixin<ExceptionAndStackTrace<T>> implements Exception {
extends Object seems a bit silly

https://codereview.chromium.org/919693007/diff/1/sky/specs/events.md#newcode33
sky/specs/events.md:33: Dispatcher<T> _dispatcher;
final

https://codereview.chromium.org/919693007/diff/1/sky/specs/events.md#newcode43
sky/specs/events.md:43: Dispatcher._internal() { }
Remove?

https://codereview.chromium.org/919693007/diff/1/sky/specs/events.md#newcode65
sky/specs/events.md:65: handler(data);
Zone?

[Hixie, 2015-02-12 19:37:59]

New patchsets have been uploaded after l-g-t-m from abarth@chromium.org

[Hixie, 2015-02-12 21:31:43]

https://codereview.chromium.org/919693007/diff/1/sky/specs/events.md
File sky/specs/events.md (right):

https://codereview.chromium.org/919693007/diff/1/sky/specs/events.md#newcode18
sky/specs/events.md:18: class ExceptionListException<T> extends Object with
IterableMixin<ExceptionAndStackTrace<T>> implements Exception {
On 2015/02/12 00:28:13, abarth wrote:
> extends Object seems a bit silly

Fixed. Turns out you just need extends IterableMixin<ExceptionAndStackTrace<T>>,
not with IterableMixin<ExceptionAndStackTrace<T>>, when you don't have a
superclass.

https://codereview.chromium.org/919693007/diff/1/sky/specs/events.md#newcode33
sky/specs/events.md:33: Dispatcher<T> _dispatcher;
On 2015/02/12 00:28:13, abarth wrote:
> final

Done.

https://codereview.chromium.org/919693007/diff/1/sky/specs/events.md#newcode43
sky/specs/events.md:43: Dispatcher._internal() { }
On 2015/02/12 00:28:13, abarth wrote:
> Remove?

Done.

https://codereview.chromium.org/919693007/diff/1/sky/specs/events.md#newcode65
sky/specs/events.md:65: handler(data);
On 2015/02/12 00:28:13, abarth wrote:
> Zone?

Done.

[Hixie, 2015-02-12 21:40:39]

Committed patchset #4 (id:60001) manually as
6311f95931f357fe9f17d19912067beede1e6e94 (presubmit successful).

[Hixie, 2015-02-12 21:41:55]

By the way I have a basic VM-level unit test for some of the top part of the
events.md code (the Dispatcher stuff). Not yet checked in. Let me know when
there's somewhere useful to put it.