Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 919693003: remove goto in Distance field path renderer (Closed)

Created:
5 years, 10 months ago by joshua.litt
Modified:
5 years, 10 months ago
Reviewers:
jvanverth1, joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove goto in Distance field path renderer BUG=skia: Committed: https://skia.googlesource.com/skia/+/9491f7ff319b0440a0e293f7d97240207f27dbdf

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -33 lines) Patch
M src/gpu/GrAADistanceFieldPathRenderer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 2 chunks +37 lines, -33 lines 1 comment Download

Messages

Total messages: 9 (3 generated)
joshualitt
5 years, 10 months ago (2015-02-11 18:02:03 UTC) #3
jvanverth1
One comment...
5 years, 10 months ago (2015-02-11 18:13:06 UTC) #4
jvanverth1
https://codereview.chromium.org/919693003/diff/1/src/gpu/GrAADistanceFieldPathRenderer.cpp File src/gpu/GrAADistanceFieldPathRenderer.cpp (right): https://codereview.chromium.org/919693003/diff/1/src/gpu/GrAADistanceFieldPathRenderer.cpp#newcode248 src/gpu/GrAADistanceFieldPathRenderer.cpp:248: if (!this->uploadPath(&plot, &atlasLocation, width, height, dfStorage.get())) { I think ...
5 years, 10 months ago (2015-02-11 18:14:20 UTC) #5
jvanverth1
On 2015/02/11 18:14:20, jvanverth1 wrote: > https://codereview.chromium.org/919693003/diff/1/src/gpu/GrAADistanceFieldPathRenderer.cpp > File src/gpu/GrAADistanceFieldPathRenderer.cpp (right): > > https://codereview.chromium.org/919693003/diff/1/src/gpu/GrAADistanceFieldPathRenderer.cpp#newcode248 > ...
5 years, 10 months ago (2015-02-11 18:22:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/919693003/1
5 years, 10 months ago (2015-02-11 19:27:39 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 19:33:41 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9491f7ff319b0440a0e293f7d97240207f27dbdf

Powered by Google App Engine
This is Rietveld 408576698