Make SkImageGenerator::getPixels() return an enum.

src/core/SkImageGenerator.cpp

 /*
  * Copyright 2014 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkImageGenerator.h"
 
 bool SkImageGenerator::getInfo(SkImageInfo* info) {
     SkImageInfo dummy;
     if (NULL == info) {
         info = &dummy;
     }
     return this->onGetInfo(info);
 }
 
-bool SkImageGenerator::getPixels(const SkImageInfo& info, void* pixels, size_t rowBytes,
-                                 SkPMColor ctable[], int* ctableCount) {
+SkImageGenerator::Result SkImageGenerator::getPixels(const SkImageInfo& info, void* pixels,
+                                                     size_t rowBytes, SkPMColor ctable[],
+                                                     int* ctableCount) {
     if (kUnknown_SkColorType == info.colorType()) {
-        return false;
+        return kInvalidConversion;
     }
     if (NULL == pixels) {
-        return false;
+        return kInvalidParameters;
     }
     if (rowBytes < info.minRowBytes()) {
-        return false;
+        return kInvalidParameters;
     }
 
     if (kIndex_8_SkColorType == info.colorType()) {
         if (NULL == ctable || NULL == ctableCount) {
-            return false;
+            return kInvalidParameters;
         }
     } else {
         if (ctableCount) {
             *ctableCount = 0;
         }
         ctableCount = NULL;
         ctable = NULL;
     }
 
-    bool success = this->onGetPixels(info, pixels, rowBytes, ctable, ctableCount);
+    const Result result = this->onGetPixelsEnum(info, pixels, rowBytes, ctable, ctableCount);
 
-    if (success && ctableCount) {
+    if ((kIncompleteInput == result || kSuccess == result) && ctableCount) {
         SkASSERT(*ctableCount >= 0 && *ctableCount <= 256);
     }
-    return success;
+    return result;
 }
 
-bool SkImageGenerator::getPixels(const SkImageInfo& info, void* pixels, size_t rowBytes) {
+SkImageGenerator::Result SkImageGenerator::getPixels(const SkImageInfo& info, void* pixels,
+                                                     size_t rowBytes) {
     SkASSERT(kIndex_8_SkColorType != info.colorType());
     if (kIndex_8_SkColorType == info.colorType()) {
-        return false;
+        return kInvalidConversion;
     }
     return this->getPixels(info, pixels, rowBytes, NULL, NULL);
 }
 
 bool SkImageGenerator::getYUV8Planes(SkISize sizes[3], void* planes[3], size_t rowBytes[3],
                                      SkYUVColorSpace* colorSpace) {
 #ifdef SK_DEBUG
     // In all cases, we need the sizes array
     SkASSERT(sizes);
 
@@ skipping 46 matching lines @@
 /////////////////////////////////////////////////////////////////////////////////////////////
 
 SkData* SkImageGenerator::onRefEncodedData() {
     return NULL;
 }
 
 bool SkImageGenerator::onGetInfo(SkImageInfo*) {
     return false;
 }
 
-bool SkImageGenerator::onGetPixels(const SkImageInfo&, void*, size_t, SkPMColor*, int*) {
-    return false;
+#ifdef SK_SUPPORT_LEGACY_IMAGE_GENERATOR_RETURN
+bool SkImageGenerator::onGetPixels(const SkImageInfo&, void*, size_t,
+                                                       SkPMColor*, int*) {
+    return kUnimplemented;
 }
+#endif
+SkImageGenerator::Result SkImageGenerator::onGetPixelsEnum(const SkImageInfo& info, void* pixels,
+                                                           size_t rowBytes, SkPMColor* colors,
+                                                           int* colorCount) {
+#ifdef SK_SUPPORT_LEGACY_IMAGE_GENERATOR_RETURN
+    if (this->onGetPixels(info, pixels, rowBytes, colors, colorCount)) {
+        return kSuccess;
+    }
+#endif
+    return kUnimplemented;
+}