Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Unified Diff: src/messages.js

Issue 919653002: [V8] Use Function.name in Error.stack (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/runtime/runtime.h » ('j') | test/mjsunit/stack-traces.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/messages.js
diff --git a/src/messages.js b/src/messages.js
index ba739987897417c7917901659d68f892cc8fe0ac..1f8ee652888c34c135d64fadacc6c95ed95f95ae 100644
--- a/src/messages.js
+++ b/src/messages.js
@@ -832,16 +832,17 @@ function CallSiteGetFunction() {
function CallSiteGetFunctionName() {
// See if the function knows its own name
- var name = GET_PRIVATE(this, CallSiteFunctionKey).name;
- if (name) {
+ var fun = GET_PRIVATE(this, CallSiteFunctionKey);
+ var name = %GetDataProperty(fun, 'name');
Yang 2015/03/10 10:48:55 How about we make this part of %FunctionGetDebugNa
kozy 2015/03/10 15:26:08 Moved to JSFunction::DebugName.
+ if (IS_STRING(name)) {
return name;
}
- name = %FunctionGetInferredName(GET_PRIVATE(this, CallSiteFunctionKey));
+ name = %FunctionGetDebugName(fun);
if (name) {
return name;
}
// Maybe this is an evaluation?
- var script = %FunctionGetScript(GET_PRIVATE(this, CallSiteFunctionKey));
+ var script = %FunctionGetScript(fun);
if (script && script.compilation_type == COMPILATION_TYPE_EVAL) {
return "eval";
}
« no previous file with comments | « no previous file | src/runtime/runtime.h » ('j') | test/mjsunit/stack-traces.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698