src/runtime/runtime-debug.cc - Issue 919653002: [V8] Use Function.name in Error.stack

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-debug.cc

Issue 919653002: [V8] Use Function.name in Error.stack (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Replaced DebugName with GetDebugName handlified version Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-debug.cc

diff --git a/src/runtime/runtime-debug.cc b/src/runtime/runtime-debug.cc

index 1856396094fadd005c80c0fdffe1fa8074a43c5f..42e60127b8b18dce3fd9f3ee4f81dfae16d762d7 100644

--- a/src/runtime/runtime-debug.cc

+++ b/src/runtime/runtime-debug.cc

@@ -2613,6 +2613,15 @@ RUNTIME_FUNCTION(Runtime_FunctionGetInferredName) {

}

+RUNTIME_FUNCTION(Runtime_FunctionGetDebugName) {

+ HandleScope scope(isolate);

+ DCHECK(args.length() == 1);

+ CONVERT_ARG_HANDLE_CHECKED(JSFunction, f, 0);

+ return *JSFunction::GetDebugName(f);

// A testing entry. Returns statement position which is the closest to

// source_position.

RUNTIME_FUNCTION(Runtime_GetFunctionCodePositionFromSource) {