Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Unified Diff: src/objects.cc

Issue 919653002: [V8] Use Function.name in Error.stack (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Replaced DebugName with GetDebugName handlified version Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.h ('k') | src/runtime/runtime.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 76be0a6495e39c0fb56fbef6180565220ec9e00b..3f15daa887a93149805e2ae823ee60d2abc02974 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -10327,6 +10327,19 @@ bool JSFunction::PassesFilter(const char* raw_filter) {
}
+Handle<String> JSFunction::GetDebugName(Handle<JSFunction> function) {
+ Isolate* isolate = function->GetIsolate();
+ Handle<Object> name =
+ JSObject::GetDataProperty(function, isolate->factory()->name_string());
+ String* debug_name = NULL;
yurys 2015/03/13 14:18:21 You should avoid raw pointers in methods that may
kozy 2015/03/13 14:54:47 Done.
+ if (name->IsString())
+ debug_name = String::cast(*name);
+ else
+ debug_name = function->shared()->DebugName();
+ return handle(debug_name, isolate);
+}
+
+
void Oddball::Initialize(Isolate* isolate,
Handle<Oddball> oddball,
const char* to_string,
« no previous file with comments | « src/objects.h ('k') | src/runtime/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698