[V8] Use Function.name in Error.stack

src/objects.cc

Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 76be0a6495e39c0fb56fbef6180565220ec9e00b..9587f8c7d0e95497efbaa0de9c602cfb75788b5f 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -10327,6 +10327,15 @@ bool JSFunction::PassesFilter(const char* raw_filter) {
 }
 
 
+String* JSFunction::DebugName() {

[Yang, 2015/03/13 13:19:13]

This is not GC-safe. GetDataProperty may cause GC, at which point the JSFunction
itself (this) may be moved and becomes invalid. Calling shared() would then
crash.

Please turn all of this into handlified code with this signature:

(static) Handle<String> JSFunction::DebugName(Handle<JSFunction>).

[kozy, 2015/03/13 14:05:14]

Done.

+  Handle<JSFunction> self(this);
+  Handle<Object> name =
+      JSObject::GetDataProperty(self, GetIsolate()->factory()->name_string());
+  if (name->IsString()) return String::cast(*name);
+  return shared()->DebugName();
+}
+
+
 void Oddball::Initialize(Isolate* isolate,
                          Handle<Oddball> oddball,
                          const char* to_string,