Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: src/objects.cc

Issue 919653002: [V8] Use Function.name in Error.stack (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.h ('k') | src/runtime/runtime.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 7315496981c600dc910c6ec0b3a844db6a61e929..4814bcbcd45c95eb708924e2617214f45dece8e2 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -10254,6 +10254,16 @@ bool JSFunction::PassesFilter(const char* raw_filter) {
}
+String* JSFunction::DebugName() {
+ HandleScope scope(GetIsolate());
kozy 2015/03/10 15:26:08 Without this handle scope some tests fails with #
+ Handle<JSFunction> self(this);
+ Handle<Object> name =
+ JSObject::GetDataProperty(self, GetIsolate()->factory()->name_string());
+ if (name->IsString()) return String::cast(*name);
+ return shared()->DebugName();
+}
+
+
void Oddball::Initialize(Isolate* isolate,
Handle<Oddball> oddball,
const char* to_string,
« no previous file with comments | « src/objects.h ('k') | src/runtime/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698