[V8] Use Function.name in Error.stack

src/messages.js

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // -------------------------------------------------------------------
 
 var kMessages = {
   // Error
   cyclic_proto:                  ["Cyclic __proto__ value"],
   code_gen_from_strings:         ["%0"],
@@ skipping 814 matching lines @@
   return script ? script.nameOrSourceURL() : null;
 }
 
 function CallSiteGetFunction() {
   return GET_PRIVATE(this, CallSiteStrictModeKey)
       ? UNDEFINED : GET_PRIVATE(this, CallSiteFunctionKey);
 }
 
 function CallSiteGetFunctionName() {
   // See if the function knows its own name
-  var name = GET_PRIVATE(this, CallSiteFunctionKey).name;
-  if (name) {
+  var fun = GET_PRIVATE(this, CallSiteFunctionKey);
+  var name = %GetDataProperty(fun, 'name');

[Yang, 2015/03/10 10:48:55]

How about we make this part of %FunctionGetDebugName as well? So that we have
one single place where we decide on what function name to display, not two
places that act as fallback to each other.

[kozy, 2015/03/10 15:26:08]

Moved to JSFunction::DebugName.

+  if (IS_STRING(name)) {
     return name;
   }
-  name = %FunctionGetInferredName(GET_PRIVATE(this, CallSiteFunctionKey));
+  name = %FunctionGetDebugName(fun);
   if (name) {
     return name;
   }
   // Maybe this is an evaluation?
-  var script = %FunctionGetScript(GET_PRIVATE(this, CallSiteFunctionKey));
+  var script = %FunctionGetScript(fun);
   if (script && script.compilation_type == COMPILATION_TYPE_EVAL) {
     return "eval";
   }
   return null;
 }
 
 function CallSiteGetMethodName() {
   // See if we can find a unique property on the receiver that holds
   // this function.
   var receiver = GET_PRIVATE(this, CallSiteReceiverKey);
@@ skipping 467 matching lines @@
 function SetUpStackOverflowBoilerplate() {
   var boilerplate = MakeRangeError('stack_overflow', []);
 
   %DefineAccessorPropertyUnchecked(
       boilerplate, 'stack', StackTraceGetter, StackTraceSetter, DONT_ENUM);
 
   return boilerplate;
 }
 
 var kStackOverflowBoilerplate = SetUpStackOverflowBoilerplate();